Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66902
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.45 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
Date: Wed, 3 Apr 2013 09:31:38 +0200
Message-ID: <CAJW__o3KBcRjg-ubD_NXQYN=5RjzGEy6ACTQ4dV07Dp6QT-=bA@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Laruence

2013/3/31 Laruence <laruence@php.net>
>    I propose to add a constant : bool CURL_WRAPPERS_ENABLE
>
>    or, any other better name...
>
>    objections?

I'm a -1 on this, because as we sort of agreed on (like Hannes
implied), this experimental feature did not turn out as we wanted, its
buggy and nobody maintains it. Currently to figure out if PHP was
built with curlwrappers, theres this dirty hack by printing the
phpinfo() page into an output buffer, to parse it for the build
string, this sucks.

However, since this is an experimental feature, we should either:
1) Make it work (most unlikely)
2) Remove it

Instead of adding tiny hacks to make it easier (I know a constant wont
hurt much). Cross version code is also gonna end up with even more
clutter, imagine this (if you want to utilize this new constant, which
is the idea right?):

$curlwrappers = false;

if(defined('CURL_WRAPPERS_ENABLED')) {
 $curlwrappers = true;
} else {
 ob_start();
 phpinfo(INFO_GENERAL);

 if(strpos('with-curlwrappers', ob_get_clean()) !== false) {
  $curlwrappers = true;
 }
}

What I'm saying is (like Hannes), adding a constant thats only gonna
be available for one minor version, is not worth it, we lived years
without it and we can live a little longer until it finally dies.



Also, seeing you already added the constant, it should be named
CURL_WRAPPERS_ENABLED, not ENABLE because it implies that its an
option used in a write context, where this constant is purely meant to
be used in a read context.



--
regards,

Kalle Sommer Nielsen
kalle@php.net