Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66898
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpcHuBT6schJm9gDe_tyz=Gvj53dNcs9UKbj2w040pCsiw@mail.gmail.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
	<CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
	<CABBJUpfx__wLqtG0w1SQzveggPiWubGLkPUJMFL+27cz3P_GyQ@mail.gmail.com>
	<CABBJUpcHuBT6schJm9gDe_tyz=Gvj53dNcs9UKbj2w040pCsiw@mail.gmail.com>
Date: Tue, 2 Apr 2013 22:56:32 -0700
Message-ID: <CADNQb0Wr4kBH638Q3mhQH_LJ8Bmo8BH_JoXtDhY+dVvYigf6kA@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: hannes.magnusson@gmail.com (Hannes Magnusson)

Wait wait wait. You are introducing a constant that is going to be
available as of 5.4.15 to 5.4.2x and then removed (as it looks like we
are agreeing)?

People have been living without this constant forever now so people
have their workarounds in place and no need to complicate their code
to for the existence of this constant which is only available for few
bugfix releases anyway?

-Hannes

On Tue, Apr 2, 2013 at 7:19 PM, Laruence <laruence@php.net> wrote:
> Added new constant CURL_WRAPPERS_ENABLE  in (include 5.4)
> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
>
> thanks
>
>
> On Mon, Apr 1, 2013 at 9:53 PM, Laruence <laruence@php.net> wrote:
>>
>>
>>
>>
>> On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson
>> <hannes.magnusson@gmail.com> wrote:
>>>
>>> On Sun, Mar 31, 2013 at 6:25 AM, Laruence <laruence@php.net> wrote:
>>> > Hey:
>>> >
>>> >    there are some issues when people run some codes in a php which is
>>> > compiled with --with-curlwrappers, like #61336, or the recently test
>>> > script
>>> > for #64433 (failed when curl wrappers enabled).
>>> >
>>> >    I know, that the curl wrapper should act the same as php http
>>> > wrapper,
>>> > but for now, we need to provide the ability to user, that they can warn
>>> > if
>>> > they codes can not run with curl wrappers..
>>> >
>>> >    here are some really usages:
>>> > https://github.com/UnionOfRAD/lithium/issues/59  and
>>> > http://weizhifeng.net/wrong-with-curlwrappers.html
>>> >
>>> >    I propose to add a constant : bool CURL_WRAPPERS_ENABLE
>>>
>>> The curl wrappers have always been a major pain, with plenty of bugs
>>> and we tend to forget to add context options there to match the
>>> standard wrapper on new feature.
>>>
>>> It has been marked as experimental since forever, and I think its time
>>> to face the failed experiment and remove it.
>>
>>
>> Hey:
>>
>>  remove is also okey for me,  but, I think it probably can only happen in
>> 5.6
>>
>>  before that,  I think a flag to 5.4+ is a good choice :)
>>
>>  thanks
>>>
>>>
>>> -Hannes
>>
>>
>>
>>
>> --
>> Laruence  Xinchen Hui
>> http://www.laruence.com/
>
>
>
>
> --
> Laruence  Xinchen Hui
> http://www.laruence.com/