Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66892
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <eece2e4b8e71c073ae35b8d57b109c54.squirrel@webmail.klapt.com>
References: <0728f531a623e3f9b7f0897a9c6fabb7.squirrel@webmail.klapt.com>
	<eece2e4b8e71c073ae35b8d57b109c54.squirrel@webmail.klapt.com>
Date: Tue, 2 Apr 2013 18:03:40 +0200
Message-ID: <CAEZPtU5CB=n5SSVDwRq4+VxdDr4ToEvSofZiym40ytYFxBob=w@mail.gmail.com>
To: Anatoliy Belsky <ab@php.net>
Cc: Derick Rethans <derick@php.net>, Gustavo Lopes <glopes@nebm.ist.utl.pt>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Fix for bug #63437
From: pierre.php@gmail.com (Pierre Joye)

hi,

On Thu, Mar 14, 2013 at 4:32 PM, Anatol Belski <ab@php.net> wrote:

>> One doubt I have yet after investigating on #62852 is that issuing
>> php_error isn't recoverable, it might be much better to throw exception in
>>  __wakeup(), just like __construct() does. This question crosses both
>> #62852  and #53437. That would work for 5.5 as unserialize() cares about
>> exceptions in __wakeup(), in 5.4 and less php_error seems to be a better
>> way. What do you think?
>>
>
> I've reuploaded the patch, removed that extra checks, fixed the relevant
> tests, removed XFAIL from bug53437.phpt and added three more.
>
> https://bugs.php.net/patch-display.php?bug_id=53437&patch=date_patch_var4.patch&revision=latest

Tests pass, crashes are gone and the patch meets the requirements
Derick asked earlier. If there is no further objection until next
Monday I will ask Anatolyi to apply it and finally fix one of the only
remaining known crash in 5.3/4, and indeed 5.5 and master (but there
are other there :).

Cheers,
--
Pierre

@pierrejoye