Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66881 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10030 invoked from network); 1 Apr 2013 13:54:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Apr 2013 13:54:12 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.171 mail-lb0-f171.google.com Received: from [209.85.217.171] ([209.85.217.171:59777] helo=mail-lb0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 34/70-07034-18199515 for ; Mon, 01 Apr 2013 08:54:10 -0500 Received: by mail-lb0-f171.google.com with SMTP id v10so1953115lbd.30 for ; Mon, 01 Apr 2013 06:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=BPxyg5GiPhWFxUL1iR6ffAxewgiQAWfLU0hHG15/bRg=; b=EpvaXM79yoIAtoYWvx1T5u1SaEhaw7cgd3wZFBkX1XAPeCxw34BXF4sGdiQxSP+MNA cpgQSxGaQIgIyi1km8sWy+5Ckp6aUvKVDBeG6lU6asBFWWrpt9MHaRoMXIp1gGePS9qB suCdbVU75lbTBsMyr8AYiMzDdA+N5+5bd+Mk6l+/VO9cU5wsTmR2YE2ETOQOIXLV/UaF zvTJgHrr+nRpIPN/aXkHwMmeFU/JxCwx5EvIed4hQoGSCv2lAfnzEHYuBu+dEO9DqAGa 9PNN8b+LXYQCfrMTxJDIsMBjAL+mmRfVsLdzCCmyw4nc/LHM/OaTz05MmeH+oemH3brM 7qHQ== X-Received: by 10.152.29.232 with SMTP id n8mr1265537lah.55.1364824446770; Mon, 01 Apr 2013 06:54:06 -0700 (PDT) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.66.196 with HTTP; Mon, 1 Apr 2013 06:53:46 -0700 (PDT) In-Reply-To: References: Date: Mon, 1 Apr 2013 21:53:46 +0800 X-Google-Sender-Auth: CUXDvsbPPHtpD5rVORtxJoFMbLA Message-ID: To: Hannes Magnusson Cc: PHP Internals Content-Type: multipart/alternative; boundary=089e0158c39c54a19e04d94cf4c4 Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers From: laruence@php.net (Laruence) --089e0158c39c54a19e04d94cf4c4 Content-Type: text/plain; charset=UTF-8 On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson wrote: > On Sun, Mar 31, 2013 at 6:25 AM, Laruence wrote: > > Hey: > > > > there are some issues when people run some codes in a php which is > > compiled with --with-curlwrappers, like #61336, or the recently test > script > > for #64433 (failed when curl wrappers enabled). > > > > I know, that the curl wrapper should act the same as php http wrapper, > > but for now, we need to provide the ability to user, that they can warn > if > > they codes can not run with curl wrappers.. > > > > here are some really usages: > > https://github.com/UnionOfRAD/lithium/issues/59 and > > http://weizhifeng.net/wrong-with-curlwrappers.html > > > > I propose to add a constant : bool CURL_WRAPPERS_ENABLE > > The curl wrappers have always been a major pain, with plenty of bugs > and we tend to forget to add context options there to match the > standard wrapper on new feature. > > It has been marked as experimental since forever, and I think its time > to face the failed experiment and remove it. > Hey: remove is also okey for me, but, I think it probably can only happen in 5.6 before that, I think a flag to 5.4+ is a good choice :) thanks > > -Hannes > -- Laruence Xinchen Hui http://www.laruence.com/ --089e0158c39c54a19e04d94cf4c4--