Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66880
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 209.85.215.181 as permitted sender)
Message-ID: <5159547F.2040804@seld.be>
Date: Mon, 01 Apr 2013 11:33:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3
MIME-Version: 1.0
To: internals@lists.php.net
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com> <CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
In-Reply-To: <CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: j.boggiano@seld.be (Jordi Boggiano)

On 01.04.2013 01:18, Hannes Magnusson wrote:
>>    I propose to add a constant : bool CURL_WRAPPERS_ENABLE

+1 on a constant if it has to stay. We had to do pretty ugly stuff to
detect it in the composer installer
https://github.com/composer/getcomposer.org/blob/master/web/installer#L135-148

> The curl wrappers have always been a major pain, with plenty of bugs
> and we tend to forget to add context options there to match the
> standard wrapper on new feature.
> 
> It has been marked as experimental since forever, and I think its time
> to face the failed experiment and remove it.

+2 for just removing it. In my experience most/all people using it just
do so by accident, because they copy pasted a configure line that had it
enabled from somewhere 5 years ago and never looked back.

Cheers

-- 
Jordi Boggiano
@seldaek - http://nelm.io/jordi