Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66877
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
References: <CABBJUpexRYZaXi10UobucCzJUXsLLK9avs+WspdSxyE4vDJ2rA@mail.gmail.com>
Date: Sun, 31 Mar 2013 16:18:52 -0700
Message-ID: <CADNQb0Uo0u2xCbR_joWKmwN9z+77nN-cLQ=Lcq2gpr0hf_A2qA@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Sun, Mar 31, 2013 at 6:25 AM, Laruence <laruence@php.net> wrote:
> Hey:
>
>    there are some issues when people run some codes in a php which is
> compiled with --with-curlwrappers, like #61336, or the recently test script
> for #64433 (failed when curl wrappers enabled).
>
>    I know, that the curl wrapper should act the same as php http wrapper,
> but for now, we need to provide the ability to user, that they can warn if
> they codes can not run with curl wrappers..
>
>    here are some really usages:
> https://github.com/UnionOfRAD/lithium/issues/59  and
> http://weizhifeng.net/wrong-with-curlwrappers.html
>
>    I propose to add a constant : bool CURL_WRAPPERS_ENABLE

The curl wrappers have always been a major pain, with plenty of bugs
and we tend to forget to add context options there to match the
standard wrapper on new feature.

It has been marked as experimental since forever, and I think its time
to face the failed experiment and remove it.

-Hannes