Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66868 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7449 invoked from network); 31 Mar 2013 05:42:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Mar 2013 05:42:11 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.123 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.123 smtp123.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.123] ([108.166.43.123:43955] helo=smtp123.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8E/D1-28949-1BCC7515 for ; Sun, 31 Mar 2013 00:42:11 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp8.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 706991A007D; Sun, 31 Mar 2013 01:42:07 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp8.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 205391A007C; Sun, 31 Mar 2013 01:42:07 -0400 (EDT) Message-ID: <5157CCAE.9050902@sugarcrm.com> Date: Sat, 30 Mar 2013 22:42:06 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Sanford Whiteman CC: Stas Malyshev References: <5157A55A.1070507@sugarcrm.com> <5157AD1D.3020606@sugarcrm.com> <1976271560.20130331010438@cypressintegrated.com> In-Reply-To: <1976271560.20130331010438@cypressintegrated.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] more secure unserialize() From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > And what about automatic un/serialize() of objects in $_SESSION? > People don't even see those function calls in their code, so dropping > the function/ality would be a wildly drastic move. Nothing about it, the change is for unserialize() function. > tread gently, as in your suggestion of an extra param. And probably > want two optional PHP.INI settings: one for when unserialize() is As we learned many times in the past, behavior-changing ini settings are not a good idea. We have to get away from mentality of "if we need to modify some behavior, we just put a variable in global state to control it". Global state is the last resort, not the first one. Variables that have local influence should have local scope. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227