Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66841
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51533A7A.8060204@gmx.net>
References: <1364337846.21443.58.camel@ghost>
	<51533A7A.8060204@gmx.net>
Date: Wed, 27 Mar 2013 21:35:57 +0100
Message-ID: <CAEZPtU49vaV5YUKS6CZ-VrKQasCy7nC29pkdQA=rY+A1RP2Czg@mail.gmail.com>
To: David Soria Parra <dsoria@gmx.net>
Cc: Anatol Belski <ab@php.net>, David Soria Parra <dsp@php.net>, 
	=?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, PHP Internals <internals@lists.php.net>, 
	jpauli <jpauli@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Re: libmagic 5.14 upgrade
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Mar 27, 2013 at 7:29 PM, David Soria Parra <dsoria@gmx.net> wrote:
> On 03/26/2013 11:44 PM, Anatol Belski wrote:
>> What +/- I personally see upgrading this at this time:
>>
>> contra:
>> - there might be bugs, the next release might have not all them fixed
>> - 5.11 is what the latest linux exts have even as dev
>> - older/custom magic files might be incompatible
>>
>> pro:
>> - latest libmagic data
>> - better safety for the future
>> - in a year all that libs are for sure upgraded in the main distros
>> - further upgrades can be better handled
>
> HI Anatol,
>
> thanks for putting this patch together. However as we already reached
> feature freeze and we are will have beta2 tomorrow I think it's a bit
> too late for so much new code. I cannot really judge the sideeffects of
> this upgrade and would prefer to be strict about the feature freeze. So
> please do not update the library unless Stas decides that he wants to do
> it in 5.4, in that case I have to go with his decision.

We have done that many times in the past for 5.3 and 5.4. It is
relatively risk free. Even more for 5.5 during beta phase. It does not
add new features but fixes bugs.

The good side effect is that we can test it well with 5.5 and back
port to 5.3/4 later.

Cheers,
--
Pierre

@pierrejoye