Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6682 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85394 invoked by uid 1010); 22 Dec 2003 23:07:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 85360 invoked from network); 22 Dec 2003 23:07:30 -0000 Received: from unknown (HELO perkunas4.omnitel.net) (194.176.32.101) by pb1.pair.com with SMTP; 22 Dec 2003 23:07:30 -0000 Received: from delfi.lt (unknown [212.47.107.40]) by perkunas4.omnitel.net (Postfix) with ESMTP id 278A71D40E4 for ; Tue, 23 Dec 2003 02:03:07 +0200 (EET) Message-ID: <3FE794F5.3010905@delfi.lt> Date: Tue, 23 Dec 2003 01:05:57 +0000 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030714 Debian/1.4-2 X-Accept-Language: en MIME-Version: 1.0 To: internals@lists.php.net Content-Type: multipart/mixed; boundary="------------040308060100030707010209" Subject: [PATCH] Nitpicking on typos From: moxliukas@delfi.lt (Petras Kudaras) --------------040308060100030707010209 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Hello, First of all I would like to appologise for possibly being too pedantic, but I have spotted some typos that might be considered to be fixed. I was reading http://qa.php.net/write-test.php and I saw that the filename REATME.TESTING was mentioned in all of the test code examples. I believe this is a typo and the filename should read README.TESTING I have therefore attached the patches that fixes those typos. While reading a README.SUBMITTING_PATCH about how to get through to you, I also spotted another typo. Patch attached. Sorry for nitpicking. -- Petras Kudaras aka moxliukas --------------040308060100030707010209 Content-Type: text/plain; name="README.SUBMITTING_PATCH.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="README.SUBMITTING_PATCH.patch.txt" Index: php-src/README.SUBMITTING_PATCH =================================================================== RCS file: /repository/php-src/README.SUBMITTING_PATCH,v retrieving revision 1.7 diff -u -r1.7 README.SUBMITTING_PATCH --- php-src/README.SUBMITTING_PATCH 8 Jul 2003 09:43:39 -0000 1.7 +++ php-src/README.SUBMITTING_PATCH 22 Dec 2003 22:53:44 -0000 @@ -90,7 +90,7 @@ to include the patch as a MIME attachment even if it is short. NOTE: only MIME attachments of type 'text/*' are accepted. The - easiest way to acclomplish this, is to make the extension + easiest way to accomplish this, is to make the extension '.txt'. Test scripts should be included in the same email. @@ -100,7 +100,7 @@ What happens after you submit your patch --------------------------------------- +---------------------------------------- If your patch is easy to review and has obviously no side-effects, it might take up to a few hours until someone commits it. --------------040308060100030707010209 Content-Type: text/plain; name="exif.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="exif.patch.txt" Index: php-src/ext/exif/tests/exif005.phpt =================================================================== RCS file: /repository/php-src/ext/exif/tests/exif005.phpt,v retrieving revision 1.5 diff -u -r1.5 exif005.phpt --- php-src/ext/exif/tests/exif005.phpt 16 Dec 2002 14:54:35 -0000 1.5 +++ php-src/ext/exif/tests/exif005.phpt 22 Dec 2003 22:46:57 -0000 @@ -7,7 +7,7 @@ zlib.output_compression=0 --FILE-- "hi", "hi"=>"hello", "a"=>"A", "world"=>"planet"); var_dump(strtr("# hi all, I said hello world! #", $trans)); ?> --------------040308060100030707010209--