Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66790 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68035 invoked from network); 25 Mar 2013 05:23:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Mar 2013 05:23:40 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.220.48 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.220.48 mail-pa0-f48.google.com Received: from [209.85.220.48] ([209.85.220.48:65255] helo=mail-pa0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 27/81-58569-B5FDF415 for ; Mon, 25 Mar 2013 00:23:40 -0500 Received: by mail-pa0-f48.google.com with SMTP id hz10so830181pad.21 for ; Sun, 24 Mar 2013 22:23:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding:x-gm-message-state; bh=n1qnNuzAKfdTYw1YRK052mezlvKG7JZh5wPMvCgqddk=; b=TbdaWJvTVYx3jxVzTsaLO0ZYnhcOIO8DbfxBWrP3MBTbc6lBloxrl/dNOnL0Fy73p8 Nfu+Cx8iR+6s3ABZpzJ3cBG/6XZd0uiSEXl0nabV2XD8EN0GircyvCpipmvQbFnQllWD eoKkn7F42qzqvWQqqEDotocldDsW8eJicnrC40BI/jI0dJnMw7YizO1uJb9UiYRqR6U/ 3cu+pllD+JY3mA7fnxRSZ9tuyWp9mELuRbn+dgytqpZlaJUu/e4mycJtnmLsInAad+iS WY+3k/gj/QifnNe/KX0/4jkteGuEz3aSa2Au//JrT1ztb5uqJ+pDzCIKkjY0SxWwRUt+ kNDQ== X-Received: by 10.68.216.226 with SMTP id ot2mr15346019pbc.99.1364189016643; Sun, 24 Mar 2013 22:23:36 -0700 (PDT) Received: from [192.168.200.148] (c-50-131-44-225.hsd1.ca.comcast.net. [50.131.44.225]) by mx.google.com with ESMTPS id rt13sm13327693pac.14.2013.03.24.22.23.35 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Mar 2013 22:23:35 -0700 (PDT) Message-ID: <514FDF56.2090004@lerdorf.com> Date: Sun, 24 Mar 2013 22:23:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Laruence CC: Felipe Pena , Remi Collet , internals References: <514C1E14.3070002@fedoraproject.org> <514F370B.7080409@lerdorf.com> <514F8E86.2020601@lerdorf.com> <514FD5AE.9060703@lerdorf.com> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQmn+FjXpboNDGIRcjVwrHryOUSrX0IF8v2FpTMZVoEeg2bX21hyFIJemzt/FqnD3mJ+xmr+ Subject: Re: [PHP-DEV] PHP 5.5.0beta1 ZTS broken build From: rasmus@lerdorf.com (Rasmus Lerdorf) On 03/24/2013 10:18 PM, Laruence wrote: > On Mon, Mar 25, 2013 at 12:42 PM, Rasmus Lerdorf wrote: >> Right, but if we handle it like we do with TSRMLS_C throughout the code >> and always set that %parse-param to this new magic macro we make up and >> have it point to void *compiler_globals for zendparse() under ZTS mode >> and void otherwise and make sure it is (re)defined correctly in other >> places? It might mean we need to refactor zenderror() to take a dummy >> first arg since it seems to prepend the parse-param type there. Messy. > > Hmm, seems fine, a patch is attached: > https://bugs.php.net/patch-display.php?bug_id=64503&patch=bison_build.patch&revision=latest > > but there must be some unused parameter term_ls while in non-zts build... > Damn you are fast. I was just theorizing that it might work and you have it implemented before I finished thinking about it. -Rasmus