Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66766 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28898 invoked from network); 23 Mar 2013 13:37:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Mar 2013 13:37:51 -0000 Authentication-Results: pb1.pair.com header.from=ondrej@sury.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ondrej@sury.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sury.org designates 209.85.128.173 as permitted sender) X-PHP-List-Original-Sender: ondrej@sury.org X-Host-Fingerprint: 209.85.128.173 mail-ve0-f173.google.com Received: from [209.85.128.173] ([209.85.128.173:59040] helo=mail-ve0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 55/00-28421-B20BD415 for ; Sat, 23 Mar 2013 08:37:49 -0500 Received: by mail-ve0-f173.google.com with SMTP id oz10so3996854veb.18 for ; Sat, 23 Mar 2013 06:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sury.org; s=google; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=jKJEfeB0lL2RNexJCVK3Q1UU9kcss6X9Vr662X1sOu4=; b=AXuNOAfbQIPJJeNAg2IC2ZfxdJ4LvxokTHoYvjYQvhvONpLaoMiAvg5k0yz54ZjRUk IrMiXyFu9y3VGA8yTcYFs2qy4BdW8OKfp37LdH6s8KZOCBCXTgUTdS1Qz5WUl9dAkTsK LSA5D1Yd1SXoxC0sd9z0AYaAA1nbzYWAVwAqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=jKJEfeB0lL2RNexJCVK3Q1UU9kcss6X9Vr662X1sOu4=; b=V00RYVLebMQa1j6CduHq0MqENa4mG/yya8HItkcGHmDan0LusqTsqhqHmXGiRw7AY/ Gu9NZ0NB6H+Tqz5lbr0u+P5BVlhB7IhAVuuJb35EXtsMRolM9eIs/+bbU0b1twoAppUR EmomLV48NxXD2Qpe5jFWVqNwGYjNSF1UD+DwhVNQtykQiJ42shANwogZMolIFbwh9OgB B1qL0sNjewIqu7Tuq6Rj76WxpqJumvSG/OPptBi4Yc0T9LLMvdm3EHqoEQa04PlF4c6L lhqHfS8Oi6ZBAZxhGcl5MqpDmv9TTOvNI3nt210Q4OOf48AQEdjEfQnOBR7fikZbV/Za kqXw== X-Received: by 10.52.31.36 with SMTP id x4mr6175144vdh.44.1364045864985; Sat, 23 Mar 2013 06:37:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.59.2.225 with HTTP; Sat, 23 Mar 2013 06:37:24 -0700 (PDT) In-Reply-To: <514CC744.8070606@sugarcrm.com> References: <514CC744.8070606@sugarcrm.com> Date: Sat, 23 Mar 2013 14:37:24 +0100 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=bcaec51d284c3d82ac04d897ad39 X-Gm-Message-State: ALoCoQnqiDqoqVGaM0CdQCCzxHpn/DNlhI+en23/DJ/x12HzUMdDr387ss/NDnmztMXiW9fZFnrc Subject: Re: [PHP-DEV] PHP5.5 beta 1 is ready From: ondrej@sury.org (=?UTF-8?B?T25kxZllaiBTdXLDvQ==?=) --bcaec51d284c3d82ac04d897ad39 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2013 at 10:04 PM, Stas Malyshev wro= te: > Hi! > > > just FYI, there's some non-portable code in Zend OpCache (alpha5 was > built > > just fine), which prevents building of php5 beta1 on non-Linux systems: > > > > FreeBSD: https://bugs.php.net/bug.php?id=3D64490 > > Hurd i386: > > > https://buildd.debian.org/status/fetch.php?pkg=3Dphp5&arch=3Dhurd-i386&ve= r=3D5.5.0~beta1-1&stamp=3D1363956014 > > > > While hurd might be not important, the general experience is that writi= ng > > portable code helps the general quality of the code :). > > We probably need to make it self-disable on systems where we don't have > suitable flock driver. It seems that GNU Hurd does implement flock(). I'll talk to Debian porter team if they can help with the issue there. > For freebsd though it's strange since it has if > defined(__FreeBSD__) clause there. Is there some other define that > should be checked instead? The attached patch to 64490 is correct GNU kFreeBSD defines __FreeBSD_kernel__, there's more info in here: http://glibc-bsd.alioth.debian.org/porting/PORTING O. --=20 =EF=BB=BFOnd=C5=99ej Sur=C3=BD --bcaec51d284c3d82ac04d897ad39--