Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66755
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.128.181 cause and error)
Message-ID: <514CDB8C.6010406@lerdorf.com>
Date: Fri, 22 Mar 2013 15:30:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: =?UTF-8?B?T25kxZllaiBTdXLDvQ==?= <ondrej@sury.org>, 
 PHP Internals <internals@lists.php.net>
References: <CAMUwpuTbT=AHmncpfVN0_8hYsgpacjyyRkY7tLE6kxEWjmCFjg@mail.gmail.com> <CALjhHG-0uQ6fsHoZ7BipKfp4athu8UHNm0ps-snss5HccEj4Zg@mail.gmail.com> <514CC744.8070606@sugarcrm.com>
In-Reply-To: <514CC744.8070606@sugarcrm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP5.5 beta 1 is ready
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 03/22/2013 02:04 PM, Stas Malyshev wrote:
> Hi!
> 
>> just FYI, there's some non-portable code in Zend OpCache (alpha5 was built
>> just fine), which prevents building of php5 beta1 on non-Linux systems:
>>
>> FreeBSD: https://bugs.php.net/bug.php?id=64490
>> Hurd i386:
>> https://buildd.debian.org/status/fetch.php?pkg=php5&arch=hurd-i386&ver=5.5.0~beta1-1&stamp=1363956014
>>
>> While hurd might be not important, the general experience is that writing
>> portable code helps the general quality of the code :).
> 
> We probably need to make it self-disable on systems where we don't have
> suitable flock driver. For freebsd though it's strange since it has if
> defined(__FreeBSD__) clause there. Is there some other define that
> should be checked instead?

Yes, Joe attached a patch to bug 64490 that fixes the check.

-Rasmus