Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66737
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ralphschindler.com from 209.85.214.177 cause and error)
Message-ID: <514B203A.80502@ralphschindler.com>
Date: Thu, 21 Mar 2013 09:59:06 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Phar Bug #60953
From: ralph@ralphschindler.com (Ralph Schindler)

Hi all,

I'd like to get some closure on this PR:

https://github.com/php/php-src/pull/297

which fixes:

https://bugs.php.net/bug.php?id=60953

I've discussed it in brief with both cjones and lawerence. I don't have 
commit karma for the phar extension, so someone will have to merge this 
for me.

In a nutshell, phar_rename_archive(), which is called from 
Phar::convertToExecutable(), incorrectly assumes anything after the 
first dot is a file extension.  This causes problems where file names 
have dots in them, and you attempt to run convertToExecutable().

This patch attempts to fix the problem by making educated guesses as to 
which the extension is (should be).  In most cases, the extension should 
include a .phar, or some known single or compound format for an 
extension (like tar.gz).

You'll notice some existing tests have changed.  This is because the 
incorrect assumption was propagated through existing tests, and that was 
fixed, all the tests pass.

Finally, if there is a file name extension Phar doesn't already 
understand, it will simply take the part after the first dot, like it 
did previously (for BC).

Anyone want to assist getting this fix into 5.3-5.5?  Or are there any 
lingering questions on the patch?

Thanks,
Ralph