Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6667
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
In-Reply-To: <200312211312.52512.ilia@prohost.org>
References: <200312211312.52512.ilia@prohost.org>
Mime-Version: 1.0 (Apple Message framework v606)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-ID: <08A4825B-340D-11D8-B114-000A95CE0C62@at.wakwak.com>
Content-Transfer-Encoding: 7bit
Cc: PHP Internals List <internals@lists.php.net>
Date: Mon, 22 Dec 2003 08:25:59 +0900
To: ilia@prohost.org
Subject: Re: [PHP-DEV] fgetcsv() conclusion
From: moriyoshi@at.wakwak.com (Moriyoshi Koizumi)

On 2003/12/22, at 3:12, Ilia Alshanetsky wrote:

> 1) Leave things they way they are now, giving everyone a partial 
> support for
> multibyte string in fgetcsv() and 2-3 performance decrease in all 
> instances.

Of course this is my choice.

> 3) Put the php_mblen macro in php_string.h inside ifdef HAVE_MBSTRING, 
> which
> would disable multibyte functionality of fgetcsv() for people without
> mbstring support in their installation. This would just about restore
> performance and at the same time leave multibyte support for people 
> who need
> it (use mbstring extension).

Why should we set up a relation to only mbstring extension here? I think
HAVE_ICONV should be take into consideration as well in case we choose
this option after all.

Regards,
Moriyoshi