Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6661
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Reply-To: ilia@prohost.org
To: PHP Internals List <internals@lists.php.net>
Date: Sun, 21 Dec 2003 13:12:52 -0500
User-Agent: KMail/1.5.94
Organization: Prohost.org
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-ID: <200312211312.52512.ilia@prohost.org>
Subject: fgetcsv() conclusion
From: ilia@prohost.org (Ilia Alshanetsky)

It's been a few days since the last comments regarding the fgetcsv() in PHP 
5.0 and I think it would be an opportune time to decide on a solution for the 
problem. Based on the various commentary we appear to have 3 alternatives 
that for better or worse would resolve the situation.

1) Leave things they way they are now, giving everyone a partial support for 
multibyte string in fgetcsv() and 2-3 performance decrease in all instances.

2) Backport fgetcsv() from 4.3.X tree, giving everyone a fast variant of the 
function and introduce a fully multibyte mb_fgetcsv() into mbstring extension 
based on the current fgetcsv() in PHP 5.0.

3) Put the php_mblen macro in php_string.h inside ifdef HAVE_MBSTRING, which 
would disable multibyte functionality of fgetcsv() for people without 
mbstring support in their installation. This would just about restore 
performance and at the same time leave multibyte support for people who need 
it (use mbstring extension).


My personal preference is option #2.

Ilia