Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66576 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99684 invoked from network); 11 Mar 2013 07:21:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Mar 2013 07:21:39 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.178 mail-lb0-f178.google.com Received: from [209.85.217.178] ([209.85.217.178:33412] helo=mail-lb0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 33/E3-09030-DF58D315 for ; Mon, 11 Mar 2013 02:21:34 -0500 Received: by mail-lb0-f178.google.com with SMTP id n1so2809402lba.23 for ; Mon, 11 Mar 2013 00:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=GKQLxHu+e3Y1TmIbKPvWZ7TZuDOMZSBuwNim200EaCU=; b=gkEvjvWuDE1655I51Fi7f/AQwlwu9FTBr9sGFtElcedCHB0POyHyxuXMocS8r/U0e1 OaK2Y/tQ+D9h9110gEtYBsZ8smy+zpEG97cZSqChZp26M9QgXALlQUeEZl+J4ksDrH64 RyKZ8p51GMXmLQsesF4Z2v0RU347dkzXpAIsBb/6lRhcI0N2mME0lFdiR9jNRQVto7R1 v9UD7PDwqRN2/563/TE+O12wgMwR2j0kEb1PJtYklyNJTKcgPRBs2Trndy3R4tTVqoih OVqq/iojvE4e0p5HgTsr99OjuUHZNotMLSMHQQ87qfuShuA7kscEA+hcBhinPQ5tU8bV 5X3g== X-Received: by 10.112.28.169 with SMTP id c9mr4221198lbh.84.1362986489861; Mon, 11 Mar 2013 00:21:29 -0700 (PDT) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.66.196 with HTTP; Mon, 11 Mar 2013 00:21:09 -0700 (PDT) In-Reply-To: References: Date: Mon, 11 Mar 2013 15:21:09 +0800 X-Google-Sender-Auth: BQjswD-xaljKmqUsfhYucp8Gl0E Message-ID: To: Dmitry Stogov Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: disable zend_always_inline in debug mode From: laruence@php.net (Laruence) On Mon, Mar 11, 2013 at 2:07 PM, Dmitry Stogov wrote: > You can do it. > thanks , committed in https://github.com/php/php-src/commit/0444708c5cd665179a936b86369f84b9dad8effe > Thanks. Dmitry. > > On Fri, Mar 8, 2013 at 7:27 PM, Laruence wrote: >> >> Hey: >> >> I propose to disable zend_alwasy_inline while build PHP in debug mode. >> >> that could be easier for debuging some bugs.. >> >> what do you think? >> >> >> thanks >> >> >> simple patch: >> >> diff --git a/Zend/zend.h b/Zend/zend.h >> index 40515fb..03bd4e7 100644 >> --- a/Zend/zend.h >> +++ b/Zend/zend.h >> @@ -365,7 +365,7 @@ struct _zval_struct { >> #define Z_UNSET_ISREF(z) Z_UNSET_ISREF_P(&(z)) >> #define Z_SET_ISREF_TO(z, isref) Z_SET_ISREF_TO_P(&(z), isref) >> >> -#if defined(__GNUC__) >> +#if defined(__GNUC__) && !ZEND_DEBUG >> #if __GNUC__ >= 3 >> #define zend_always_inline inline __attribute__((always_inline)) >> #define zend_never_inline __attribute__((noinline)) >> @@ -374,7 +374,7 @@ struct _zval_struct { >> #define zend_never_inline >> #endif >> >> -#elif defined(_MSC_VER) >> +#elif defined(_MSC_VER) && !ZEND_DEBUG >> #define zend_always_inline __forceinline >> #define zend_never_inline >> #else >> >> >> >> -- >> Laruence Xinchen Hui >> http://www.laruence.com/ > > -- Laruence Xinchen Hui http://www.laruence.com/