Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66574
Return-Path: <dmitry@zend.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 93004 invoked from network); 11 Mar 2013 06:07:37 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Mar 2013 06:07:37 -0000
Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.214.171 as permitted sender)
X-PHP-List-Original-Sender: dmitry@zend.com
X-Host-Fingerprint: 209.85.214.171 mail-ob0-f171.google.com  
Received: from [209.85.214.171] ([209.85.214.171:62954] helo=mail-ob0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E3/B2-09030-1A47D315 for <internals@lists.php.net>; Mon, 11 Mar 2013 01:07:31 -0500
Received: by mail-ob0-f171.google.com with SMTP id x4so2970971obh.16
        for <internals@lists.php.net>; Sun, 10 Mar 2013 23:07:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=mime-version:x-received:in-reply-to:references:date:message-id
         :subject:from:to:cc:content-type:x-gm-message-state;
        bh=7R14IvteDInUe2G7Cn2+Fl4IB6c8iOrxO9UGHmuDQxs=;
        b=osm+3fePL+pigo5weSFfgeyDkMCA1BqIB6DeJZ0gBoEstOuvoJ8huF6XQV+8mYF8gA
         3YXnnvHbzy+wnmeJEIxYfueZ/Jx5WECEpThuHUCtbhS+iDjFcucgzPdcnFvH83H4oK5G
         KPEvapF0mTIdarNYcFROEutZ0NoAw/VPMuxWIS9JEU5t1I8yuccnwNwH8wALZEPJOhQB
         Alez0WOW+rW/jCWcDhldLxucSHtnVu6oW0SFLbWyzC27TJGa3khBS992fgy1jX+gRsCa
         d/OySqEyafNaX4gMnUdHzESjzHOB0X9RaOC/GgORZDMclJSjIZ/Rhd76QX4Ev0v5kFcV
         4WyA==
MIME-Version: 1.0
X-Received: by 10.182.156.44 with SMTP id wb12mr7693701obb.20.1362982046491;
 Sun, 10 Mar 2013 23:07:26 -0700 (PDT)
Received: by 10.182.242.79 with HTTP; Sun, 10 Mar 2013 23:07:26 -0700 (PDT)
In-Reply-To: <CABBJUpeu8y3yx-VRBnUQBtqNE7T-i0WkVrpxOmaKUdd4P6A2sA@mail.gmail.com>
References: <CABBJUpeu8y3yx-VRBnUQBtqNE7T-i0WkVrpxOmaKUdd4P6A2sA@mail.gmail.com>
Date: Mon, 11 Mar 2013 10:07:26 +0400
Message-ID: <CA+9eiLudrPt+6Rj1kYgUJU-O4OJ5mhp5o6ezWVQ7fwqLAO_BpQ@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0444ed37b7d0ab04d79ffc63
X-Gm-Message-State: ALoCoQky8fDZp7vg9vuSrRZAaM8g+f6QPp4/loGC152wxb2OyZle01ZY805ByIHJyc0FrcIIiV4KmTnRd/iPpJ/A9jnvw3VHjfwBheCbXAs7Xx0KMsXriYOxwUoEQAnTPxP5VLhUoQ/R
Subject: Re: disable zend_always_inline in debug mode
From: dmitry@zend.com (Dmitry Stogov)

--f46d0444ed37b7d0ab04d79ffc63
Content-Type: text/plain; charset=UTF-8

You can do it.

Thanks. Dmitry.

On Fri, Mar 8, 2013 at 7:27 PM, Laruence <laruence@php.net> wrote:

> Hey:
>
>    I propose to disable zend_alwasy_inline while build PHP in debug mode.
>
>    that could be easier for debuging some bugs..
>
>    what do you think?
>
>
> thanks
>
>
>    simple patch:
>
> diff --git a/Zend/zend.h b/Zend/zend.h
> index 40515fb..03bd4e7 100644
> --- a/Zend/zend.h
> +++ b/Zend/zend.h
> @@ -365,7 +365,7 @@ struct _zval_struct {
>  #define Z_UNSET_ISREF(z)               Z_UNSET_ISREF_P(&(z))
>  #define Z_SET_ISREF_TO(z, isref)       Z_SET_ISREF_TO_P(&(z), isref)
>
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) && !ZEND_DEBUG
>  #if __GNUC__ >= 3
>  #define zend_always_inline inline __attribute__((always_inline))
>  #define zend_never_inline __attribute__((noinline))
> @@ -374,7 +374,7 @@ struct _zval_struct {
>  #define zend_never_inline
>  #endif
>
> -#elif defined(_MSC_VER)
> +#elif defined(_MSC_VER) && !ZEND_DEBUG
>  #define zend_always_inline __forceinline
>  #define zend_never_inline
>  #else
>
>
>
> --
> Laruence  Xinchen Hui
> http://www.laruence.com/
>

--f46d0444ed37b7d0ab04d79ffc63--