Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66572 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99666 invoked from network); 9 Mar 2013 23:49:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Mar 2013 23:49:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:42836] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BC/62-19169-38ACB315 for ; Sat, 09 Mar 2013 18:49:25 -0500 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 4C631DE13E; Sat, 9 Mar 2013 23:49:15 +0000 (GMT) Date: Sat, 9 Mar 2013 23:49:15 +0000 (GMT) X-X-Sender: derick@whisky.home.derickrethans.nl To: Gustavo Lopes cc: Anatol Belski , internals@lists.php.net In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Fix for bug #63437 From: derick@php.net (Derick Rethans) On Sat, 9 Mar 2013, Gustavo Lopes wrote: > On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans wrote: > > > On Tue, 5 Mar 2013, Anatol Belski wrote: > > > > > I've reworked the patch from > > > http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff > > > (mentioned by tony2001) for bug #63437, that seems to fix the > > > issue. That patch was ported back to 5.3 and adapted to the > > > current 5.4+. Both variants are posted to the ticket. > > > > Serializing this as a base64 encoded variant of some binary data is > > not a good thing. If you want to serialize, it needs to output the > > same thigns that allow users to create the period or interval. > > I would agree in principle, but, as I explained before, there is a > problem. The DatePeriod class has 64-bit integers in its internal > structure. The PHP integer type cannot (in general) represent that > data. So the general method of getting the object data via > get_properties and serializing (and then using __set_state to convert > the array back) does not work unless you represent those 64-bit > integers with some non-integer type and do the conversions. Then store them as strings or another format that makes it possible to get a 64bit timestamp back. Of course, I don't think it makes too much sense to serialize a Period as it's more of a transient iterator wrapper. For an interval, you'd want to serialise the original input vectors as well... not an easy task (unless you store the original). cheers, Derick