Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66570
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsWNV7H1zAr1U-wPafz9SzB=eR_C33RQKgqy1Tx1+X8gw@mail.gmail.com>
References: <CAF+90c-E7n-WZcqNg28bX+G7zgbzhKoNCwR6hf++tfAgSzmtTw@mail.gmail.com>
	<CAF+90c-wSqeff_2oY8HeY+gDn-ZnwJeXKQ+cz-1W6xcEBjs+xw@mail.gmail.com>
	<CA+9eiLtiOcFuxRXhpGXe5b9SpyVPB1_ixJ4t1GQ3J1bvBURMKA@mail.gmail.com>
	<CAF+90c92AwjX7Niro_tT5vOv+vHeY-AmgfizL5f9i1FYhKTz2A@mail.gmail.com>
	<CA+9eiLsWNV7H1zAr1U-wPafz9SzB=eR_C33RQKgqy1Tx1+X8gw@mail.gmail.com>
Date: Sat, 9 Mar 2013 22:47:56 +0100
Message-ID: <CAF+90c_Nt=Q-vTHO3iqC24mkwULMvV+KxpYpy1ug5=7em-x1eg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>, Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>
Content-Type: multipart/alternative; boundary=14dae93b5c808a19c104d784e439
Subject: Re: [PHP-DEV] Re: [VOTE] Allow non-scalar keys in foreach
From: nikita.ppv@gmail.com (Nikita Popov)

--14dae93b5c808a19c104d784e439
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Mar 6, 2013 at 6:28 PM, Dmitry Stogov <dmitry@zend.com> wrote:

>
>> I wonder what would be a good way to avoid allocating a temporary zval
>> for the key and freeing it again. Do you think it would be okay to pass
>> &EX_T((opline+1)->result.var).tmp_var into ->get_current_key() so the value
>> can be written directly into it without doing extra allocs/frees?
>>
>>
> I'm not sure it'll work. TMP_VARs don't initialize refcount, they can't be
> referenced or marked as a possible root of garbage.
> I took only a very quick look over the patch and didn't understand all the
> details, but probably it must be possible to copy iterator key into TMP_VAR
> and call copy_ctor().
>
> Please, let me review the patch when it's ready (I won't be available on
> March 8 and weekend).
>
> Thanks. Dmitry.
>

Here is the new patch:
https://github.com/nikic/php-src/commit/a1bfc8105713eeb4e66e852b81884b567ad56020
It passes in the tmp_var in as a zval*, which can then be set using the
ZVAL_* macros (basically the same way as it's done with return_value). This
way we don't need any further zval allocs and frees. It also turned out
that doing it this way is more convenient to use in the respective key
handlers.

Nikita

--14dae93b5c808a19c104d784e439--