Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66560 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53277 invoked from network); 8 Mar 2013 15:57:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Mar 2013 15:57:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.46 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 209.85.216.46 mail-qa0-f46.google.com Received: from [209.85.216.46] ([209.85.216.46:33312] helo=mail-qa0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D2/F1-41197-45A0A315 for ; Fri, 08 Mar 2013 10:57:08 -0500 Received: by mail-qa0-f46.google.com with SMTP id o13so3954265qaj.19 for ; Fri, 08 Mar 2013 07:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=9zQKyjomgUTOkRKErNgBvWjyCFWU15ofpmxygvVbCOw=; b=gsxmP92nKosqtR8QaTzEVy1spsx48hkAey9P/A9JEujbQwlaDfihZ/U8aSjB1rkvqn DF244Se1l/njUv03Ddmxz4ZKoaORxhMaZU1+/EQkxPt/ehaZuxw2mOI2sRi+G7l7ujbw Z2iVlQadxAIAIRYD1GIr+R5qTzVAtr6xqfKOO3bV1AlrqkPNJjSXBRdT2etuhdeRhW95 8dAeWAMzf5OY3kHAdMP0KfZ0W6x8lYsSu3dDXuu2ZD0Z8VG9Et5C7VZ7q9uFPHxXktSU 9IeygBMdbeaVCOfbqUwGvOpqSCnEudfMJNHEXBZLs0JZlXtGpmsKAvCSac4X70bsCqgh LpIA== X-Received: by 10.49.86.35 with SMTP id m3mr4518611qez.13.1362758220997; Fri, 08 Mar 2013 07:57:00 -0800 (PST) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.49.70.226 with HTTP; Fri, 8 Mar 2013 07:56:20 -0800 (PST) In-Reply-To: References: Date: Fri, 8 Mar 2013 16:56:20 +0100 X-Google-Sender-Auth: 2OcAU4U6Cnx7J5yMqRCfE3RsGUs Message-ID: To: Laruence Cc: Dmitry Stogov , PHP Internals Content-Type: multipart/alternative; boundary=047d7bdc7f8aad6d5104d76bdfb0 Subject: Re: [PHP-DEV] disable zend_always_inline in debug mode From: jpauli@php.net (Julien Pauli) --047d7bdc7f8aad6d5104d76bdfb0 Content-Type: text/plain; charset=ISO-8859-1 I ran some benchs, on my current machine (wasnt isolated to run tests). I ran micro_bench.php on master branch today : debug on, inline enabled : Total 30.688 debug on, inline disabled : Total 35.377 debug off, inline enabled : Total 10.130 debug off, inline disabled : Total 10.678 Julien.Pauli On Fri, Mar 8, 2013 at 4:32 PM, Julien Pauli wrote: > On Fri, Mar 8, 2013 at 4:27 PM, Laruence wrote: > >> Hey: >> >> I propose to disable zend_alwasy_inline while build PHP in debug mode. >> >> that could be easier for debuging some bugs.. >> >> what do you think? >> >> >> thanks >> >> >> simple patch: >> >> diff --git a/Zend/zend.h b/Zend/zend.h >> index 40515fb..03bd4e7 100644 >> --- a/Zend/zend.h >> +++ b/Zend/zend.h >> @@ -365,7 +365,7 @@ struct _zval_struct { >> #define Z_UNSET_ISREF(z) Z_UNSET_ISREF_P(&(z)) >> #define Z_SET_ISREF_TO(z, isref) Z_SET_ISREF_TO_P(&(z), isref) >> >> -#if defined(__GNUC__) >> +#if defined(__GNUC__) && !ZEND_DEBUG >> #if __GNUC__ >= 3 >> #define zend_always_inline inline __attribute__((always_inline)) >> #define zend_never_inline __attribute__((noinline)) >> @@ -374,7 +374,7 @@ struct _zval_struct { >> #define zend_never_inline >> #endif >> >> -#elif defined(_MSC_VER) >> +#elif defined(_MSC_VER) && !ZEND_DEBUG >> #define zend_always_inline __forceinline >> #define zend_never_inline >> #else >> >> >> > > I'm +1 with that. > > Julien.Pauli > --047d7bdc7f8aad6d5104d76bdfb0--