Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66559
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 50649 invoked from network); 8 Mar 2013 15:33:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Mar 2013 15:33:14 -0000
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.54 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.128.54 mail-qe0-f54.google.com  
Received: from [209.85.128.54] ([209.85.128.54:65384] helo=mail-qe0-f54.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 25/81-41197-9B40A315 for <internals@lists.php.net>; Fri, 08 Mar 2013 10:33:13 -0500
Received: by mail-qe0-f54.google.com with SMTP id i11so1024855qej.41
        for <internals@lists.php.net>; Fri, 08 Mar 2013 07:33:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=x-received:mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type;
        bh=XG5n75g6jk3+qO6DILlmdu9iBzMqZ/wAZLFJqzZVVrI=;
        b=eHgK79IRr9DZDRgZfynIzRWx2b9g7QC8ay0e4aIMTjr05EsPA/ArULqgZK7/7bmPLp
         mBCBvaXjDLJUCA8eTS2QVOWXvjhQ5JO1CNIjIjqnAocOw29TIHMjpfHfHgCwq79pYW70
         wa0CvXPs6KQYTtz1YJTas+1C6+n9eNBbNjiTU1tr+mxHCWQx6shhcYUIp3zesH0mYtqZ
         0nyH7eLGMeUkfO2V5iQUy58L1k01OUsrBxBtNOs8gYNIBdpcxpb/bsI2JV/SJORj/3fe
         oIgsvLREoFAcWogh0jg0NLjy/FKEksSJrv3/8npyrxCfuLIBouKHFTmYCO9Gd0anO0bK
         9AOA==
X-Received: by 10.224.108.136 with SMTP id f8mr4405744qap.46.1362756785637;
 Fri, 08 Mar 2013 07:33:05 -0800 (PST)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.49.70.226 with HTTP; Fri, 8 Mar 2013 07:32:25 -0800 (PST)
In-Reply-To: <CABBJUpeu8y3yx-VRBnUQBtqNE7T-i0WkVrpxOmaKUdd4P6A2sA@mail.gmail.com>
References: <CABBJUpeu8y3yx-VRBnUQBtqNE7T-i0WkVrpxOmaKUdd4P6A2sA@mail.gmail.com>
Date: Fri, 8 Mar 2013 16:32:25 +0100
X-Google-Sender-Auth: 0bbMupdFmSD5WtZMSIs9OaIZy1E
Message-ID: <CAMUwpuRE1tnLKGHiYoYnWfdrRv9fC+dxZM8MSiFa5WM2SxSsiQ@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3074b6961f909a04d76b8a3e
Subject: Re: [PHP-DEV] disable zend_always_inline in debug mode
From: jpauli@php.net (Julien Pauli)

--20cf3074b6961f909a04d76b8a3e
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Mar 8, 2013 at 4:27 PM, Laruence <laruence@php.net> wrote:

> Hey:
>
>    I propose to disable zend_alwasy_inline while build PHP in debug mode.
>
>    that could be easier for debuging some bugs..
>
>    what do you think?
>
>
> thanks
>
>
>    simple patch:
>
> diff --git a/Zend/zend.h b/Zend/zend.h
> index 40515fb..03bd4e7 100644
> --- a/Zend/zend.h
> +++ b/Zend/zend.h
> @@ -365,7 +365,7 @@ struct _zval_struct {
>  #define Z_UNSET_ISREF(z)               Z_UNSET_ISREF_P(&(z))
>  #define Z_SET_ISREF_TO(z, isref)       Z_SET_ISREF_TO_P(&(z), isref)
>
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) && !ZEND_DEBUG
>  #if __GNUC__ >= 3
>  #define zend_always_inline inline __attribute__((always_inline))
>  #define zend_never_inline __attribute__((noinline))
> @@ -374,7 +374,7 @@ struct _zval_struct {
>  #define zend_never_inline
>  #endif
>
> -#elif defined(_MSC_VER)
> +#elif defined(_MSC_VER) && !ZEND_DEBUG
>  #define zend_always_inline __forceinline
>  #define zend_never_inline
>  #else
>
>
>

I'm +1 with that.

Julien.Pauli

--20cf3074b6961f909a04d76b8a3e--