Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66558 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48888 invoked from network); 8 Mar 2013 15:27:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Mar 2013 15:27:50 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.174 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.174 mail-lb0-f174.google.com Received: from [209.85.217.174] ([209.85.217.174:43326] helo=mail-lb0-f174.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 87/21-41197-1730A315 for ; Fri, 08 Mar 2013 10:27:46 -0500 Received: by mail-lb0-f174.google.com with SMTP id l12so1421152lbo.19 for ; Fri, 08 Mar 2013 07:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:from:date:x-google-sender-auth :message-id:subject:to:cc:content-type; bh=Ivy4j2jBikeVlNx19DSMbRzFCGrnsBBUtMapxUKAaC8=; b=LePzSdMguCdUZAkJqPs4FfDZB3dEXsaL7SkuelA3oqUScRfx9imz4wyDhxnYFjRbm8 I9Yk6Q+8A76AYI7ndjr0jSBNizvw+E6Il7L7S0IdNRTXyY5sNjkxScgRlihOYMFNJiV1 5VBfA6qhbQgn2mzGVoavQNRkEBOhP2Zc8Dmj/bPVcMgKkVcYFlpxZemvR4buwrkmtdW9 y19NuygC5AwGJ/rEiKdluKYsuavB0wN6YlAp4Dqsy4f++Vtcnzs63cPWBLdwR8LSbU0K sz/3Rels2fMXaonm5stpVN2pWANv7xqGvzqIkptZT+1w2kHJictuqaoIABM2MyB2k//G tCWw== X-Received: by 10.152.147.36 with SMTP id th4mr2401847lab.19.1362756462370; Fri, 08 Mar 2013 07:27:42 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.66.196 with HTTP; Fri, 8 Mar 2013 07:27:22 -0800 (PST) Date: Fri, 8 Mar 2013 23:27:22 +0800 X-Google-Sender-Auth: UCJv_Cm1PJ9mm2pLMbH-3iZS4P8 Message-ID: To: Dmitry Stogov Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: disable zend_always_inline in debug mode From: laruence@php.net (Laruence) Hey: I propose to disable zend_alwasy_inline while build PHP in debug mode. that could be easier for debuging some bugs.. what do you think? thanks simple patch: diff --git a/Zend/zend.h b/Zend/zend.h index 40515fb..03bd4e7 100644 --- a/Zend/zend.h +++ b/Zend/zend.h @@ -365,7 +365,7 @@ struct _zval_struct { #define Z_UNSET_ISREF(z) Z_UNSET_ISREF_P(&(z)) #define Z_SET_ISREF_TO(z, isref) Z_SET_ISREF_TO_P(&(z), isref) -#if defined(__GNUC__) +#if defined(__GNUC__) && !ZEND_DEBUG #if __GNUC__ >= 3 #define zend_always_inline inline __attribute__((always_inline)) #define zend_never_inline __attribute__((noinline)) @@ -374,7 +374,7 @@ struct _zval_struct { #define zend_never_inline #endif -#elif defined(_MSC_VER) +#elif defined(_MSC_VER) && !ZEND_DEBUG #define zend_always_inline __forceinline #define zend_never_inline #else -- Laruence Xinchen Hui http://www.laruence.com/