Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66513
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.116.47 as permitted sender)
Message-ID: <BLU0-SMTP3621493A3552AADDA6E4F6CE2E40@phx.gbl>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_8F7B048E-B455-4F71-843D-CBF6889DBB2D"
MIME-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
In-Reply-To: <CAArmra0z7gbB70C9HhwHKsJcyH5c1oRBARJqKv=++MGpM2PPRQ@mail.gmail.com>
Date: Wed, 6 Mar 2013 23:36:25 +0100
CC: PHP Mailing List Developers <internals@lists.php.net>
References: <BLU0-SMTP206C4478D1BDF85B7E26DC3E2E40@phx.gbl> <CAArmra3JJ1x266ZJDJFWfRiuT5Cx9yOfL-9BFQtzSyoEzyd8NA@mail.gmail.com> <DUB403-EAS14790AB3B6CCE080364ACF3E2E40@phx.gbl> <CAArmra0ew4av+BQnyP2qCtHwfAw4KH_Pk_vsmdOOg4ZkW8LpAw@mail.gmail.com> <BLU0-SMTP26D2D1F65A3CAE9E0D4165E2E40@phx.gbl> <CAArmra0z7gbB70C9HhwHKsJcyH5c1oRBARJqKv=++MGpM2PPRQ@mail.gmail.com>
To: Will Fitch <wfitch@meetme.com>
Subject: Re: [PHP-DEV] [RFC] unset(): return bool if the variable has existed
From: bobwei9@hotmail.com (Bob Weinand)

--Apple-Mail=_8F7B048E-B455-4F71-843D-CBF6889DBB2D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am 6.3.2013 um 23:30 schrieb Will Fitch <wfitch@meetme.com>:
> On Wed, Mar 6, 2013 at 5:25 PM, Bob Weinand <bobwei9@hotmail.com> =
wrote:
> Am 6.3.2013 um 22:50 schrieb Will Fitch <willfitch@php.net>:
>> On Wed, Mar 6, 2013 at 4:44 PM, Bob Weinand <bobwei9@hotmail.com> =
wrote:
>> Am 06.03.2013 um 22:39 schrieb "Will Fitch" <willfitch@php.net>:
>>> On Wed, Mar 6, 2013 at 4:10 PM, Bob Weinand <bobwei9@hotmail.com> =
wrote:
>>> Hi!
>>>=20
>>> As this seem to require a RFC, here is it:
>>>=20
>>> https://wiki.php.net/rfc/unset_bool
>>>=20
>>> I'm not a fan of this change, but if it's going to be discussed, the =
RFC should include baseline and RFC change benchmarks. =20
>>> =20
>>>=20
>>>=20
>>> Please feedback,
>>>=20
>>> Bob Weinand
>>>=20
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>=20
>> I don't see here a real need for a benchmark as it is mostly only =
returning SUCCESS or FAILURE instead of nothing. Nothing what would slow =
PHP down.
>>=20
>> Any change to a language construct which requires additional =
processing adds time.  It may be in minute, but it's part of the =
discussion.  Since this core change you're requesting comments for =
introduces a usecase which many will not find useful (probably most =
voting), it is your responsibility to convince this category of people =
that the tradeoff won't affect them that much.
>>=20
>> If you choose not to add benchmarking, I will guarantee a -1 from me.
>> =20
>>=20
>> Bob Weinand
>=20
>=20
> I have tried the following:
>=20
> time ./sapi/cli/php -r 'while($i++ < 1e7) { $a =3D true; unset($a); }'
>=20
> Unpatched: average of 5x executed:
> real	0m4.935s
> user	0m4.925s
> sys	0m0.008s
>=20
> Patched: average of 5x executed:
> real	0m4.945s
> user	0m4.938s
> sys	0m0.005s
>=20
>=20
> Yes, there is an increase of 0.15%. This is 1 nanosecond more than =
previous.
>=20
> Is this exact enough? Or do you need more precision?
>=20
> If yes, I'll put this into the RFC.
>=20
> Thank you.  Please do add to the RFC
> =20
>=20
>=20
> Bob Weinand

RFC updated.

Any other comments about this RFC?

Bob Weinand=

--Apple-Mail=_8F7B048E-B455-4F71-843D-CBF6889DBB2D--