Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66512
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain meetme.com designates 74.125.149.143 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BLU0-SMTP26D2D1F65A3CAE9E0D4165E2E40@phx.gbl>
References: <BLU0-SMTP206C4478D1BDF85B7E26DC3E2E40@phx.gbl>
	<CAArmra3JJ1x266ZJDJFWfRiuT5Cx9yOfL-9BFQtzSyoEzyd8NA@mail.gmail.com>
	<DUB403-EAS14790AB3B6CCE080364ACF3E2E40@phx.gbl>
	<CAArmra0ew4av+BQnyP2qCtHwfAw4KH_Pk_vsmdOOg4ZkW8LpAw@mail.gmail.com>
	<BLU0-SMTP26D2D1F65A3CAE9E0D4165E2E40@phx.gbl>
Date: Wed, 6 Mar 2013 17:30:42 -0500
Message-ID: <CAArmra0z7gbB70C9HhwHKsJcyH5c1oRBARJqKv=++MGpM2PPRQ@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b6787d2f5b74704d74923c8
Subject: Re: [PHP-DEV] [RFC] unset(): return bool if the variable has existed
From: wfitch@meetme.com (Will Fitch)

--047d7b6787d2f5b74704d74923c8
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Mar 6, 2013 at 5:25 PM, Bob Weinand <bobwei9@hotmail.com> wrote:

> Am 6.3.2013 um 22:50 schrieb Will Fitch <willfitch@php.net>:
>
> On Wed, Mar 6, 2013 at 4:44 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
>
>> Am 06.03.2013 um 22:39 schrieb "Will Fitch" <willfitch@php.net>:
>>
>> On Wed, Mar 6, 2013 at 4:10 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
>>
>>> Hi!
>>>
>>> As this seem to require a RFC, here is it:
>>>
>>> https://wiki.php.net/rfc/unset_bool
>>
>>
>> I'm not a fan of this change, but if it's going to be discussed, the RFC
>> should include baseline and RFC change benchmarks.
>>
>>
>>>
>>>
>>> Please feedback,
>>>
>>> Bob Weinand
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>
>> I don't see here a real need for a benchmark as it is mostly only
>> returning SUCCESS or FAILURE instead of nothing. Nothing what would slow
>> PHP down.
>>
>
> Any change to a language construct which requires additional processing
> adds time.  It may be in minute, but it's part of the discussion.  Since
> this core change you're requesting comments for introduces a usecase which
> many will not find useful (probably most voting), it is your responsibility
> to convince this category of people that the tradeoff won't affect them
> that much.
>
> If you choose not to add benchmarking, I will guarantee a -1 from me.
>
>
>>
>> Bob Weinand
>>
>
> I have tried the following:
>
> time ./sapi/cli/php -r 'while($i++ < 1e7) { $a = true; unset($a); }'
>
> Unpatched: average of 5x executed:
> real 0m4.935s
> user 0m4.925s
> sys 0m0.008s
>
> Patched: average of 5x executed:
> real 0m4.945s
> user 0m4.938s
> sys 0m0.005s
>
>
> Yes, there is an increase of 0.15%. This is 1 nanosecond more than
> previous.
>
> Is this exact enough? Or do you need more precision?
>
> If yes, I'll put this into the RFC.
>

Thank you.  Please do add to the RFC


>
>
> Bob Weinand
>
>

--047d7b6787d2f5b74704d74923c8--