Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66246
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALrkBja3i4Za=GE7QkbsnC-pa8ogkXdaQqqCWqOaA3s6srD_KA@mail.gmail.com>
References: <CALrkBja3i4Za=GE7QkbsnC-pa8ogkXdaQqqCWqOaA3s6srD_KA@mail.gmail.com>
Date: Tue, 26 Feb 2013 16:25:03 +0100
Message-ID: <CAF+90c8cShiOqKXGA+xyVjKtnpyvZ2cO=-EHc55zkLKxHBs7nA@mail.gmail.com>
To: Mike Willbanks <pencap@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec5540980f708e204d6a242be
Subject: Re: [PHP-DEV] Add get_object_constants and get_class_constants
From: nikita.ppv@gmail.com (Nikita Popov)

--bcaec5540980f708e204d6a242be
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Feb 26, 2013 at 4:19 PM, Mike Willbanks <pencap@gmail.com> wrote:

> Hello All,
>
> Before drafting an RFC I would like to gauge interest in adding:
> get_object_constants and get_class_constants
>
> Currently this can only be done through ReflectionClass which is far slower
> than retrieving them directly from the constants table.  Some simple
> timings show that through reflection retrieving these values is 2-3 times
> slower than providing a quick access function for retrieval.
>
> This also fits nicely amongst the current stack of:
> get_object_vars, get_class_vars and get_class_methods
>
> These functions are commonly asked about on areas such as StackOverflow (
>
> http://stackoverflow.com/questions/956401/can-i-get-consts-defined-on-a-php-class
> )
> amongst other places on the net.
>
> I have already drafted up a PR with the changes and supplemental data:
> https://github.com/php/php-src/pull/292
>
> Regards,
>
> Mike
>

I don't quite see why we need this. The only argument seems to be
performance and I'm not quite sure why performance would be relevant here.
At least I can't imagine in what kind of code fetching the class constants
is a bottleneck.

Nikita

--bcaec5540980f708e204d6a242be--