Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66193
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CACQesk4WuORy6snpu-izF2TwFqCBnzCPMQDzn8L+ho+iDuwmHA@mail.gmail.com>
References: <CAF+90c-F4DO93owuYOHOVjnEwEmohiTiUMU6VXM2t1+PRSzKaQ@mail.gmail.com>
	<alpine.DEB.2.02.1302191323090.5054@whisky.home.derickrethans.nl>
	<CACQesk5TykzLe==yCrDXg3zh+XfLahhBu7yOFdKeKjDBYzaXCA@mail.gmail.com>
	<alpine.DEB.2.02.1302191351290.5054@whisky.home.derickrethans.nl>
	<CACQesk4WuORy6snpu-izF2TwFqCBnzCPMQDzn8L+ho+iDuwmHA@mail.gmail.com>
Date: Mon, 25 Feb 2013 15:58:36 +0100
Message-ID: <CAF+90c-qjCsZnyHsqodS-ba3XULG0nXdy2wWjf+HPAAxSgf9Rw@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec55409808e58eb04d68dc61c
Subject: Re: [PHP-DEV] [RFC] Allow non-scalar keys in foreach
From: nikita.ppv@gmail.com (Nikita Popov)

--bcaec55409808e58eb04d68dc61c
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Feb 19, 2013 at 3:12 PM, Etienne Kneuss <colder@php.net> wrote:

>
>
>
> On Tue, Feb 19, 2013 at 2:55 PM, Derick Rethans <derick@php.net> wrote:
>
>> Gah, no top posting!
>>
>> On Tue, 19 Feb 2013, Etienne Kneuss wrote:
>>
>> > On Tue, Feb 19, 2013 at 2:25 PM, Derick Rethans <derick@php.net> wrote:
>> >
>> > > On Tue, 19 Feb 2013, Nikita Popov wrote:
>> > >
>> > > > This RFC proposes to remove the type-restrictions on Iterator keys
>> > > > used in foreach:
>> > > >
>> > > > https://wiki.php.net/rfc/foreach-non-scalar-keys
>> > > >
>> > > > I took over Levi's RFC and added a patch for it.
>> > >
>> > > Under "Open Questions" you write:
>> > >
>> > > > What should be done with the keys that are valid in the iterator,
>> > > > but not in the array? I think the best approach would be to just
>> > > > set the array keys with the exact same semantics as PHP would do
>> > > > (i.e. with all casts and warnings).
>> > >
>> > > Would __toString be called in case the key was an object?
>>
>> > I think the warning can stay as-is, __toString is not necessarily
>> > available so casting to string in all occasions is probably not what
>> > we want.
>>
>> I think it should cast to a string if possible. You are now making
>> iterator_to_array not work with the new feature, and I find that a bit
>> silly. Whether it should be __toString (or __toKey) I don't really care,
>> but this new support for objects should be supported everywhere (and
>> that includes iterator_to_array).
>>
>
> I think this RFC is orthogonal to iterator_to_array supporting conversions
> from objects to keys.
>
> $array[$obj] = 42; does not call __toString (or __toKey), it throws a
> catchable fatal. IMO it would be inconsistent if iterator_to_array
> gracefully accepted objects as keys.
>

I updated the patch to use the usual array assignment behavior. I.e. the
behavior will be the same as the following code:

function iterator_to_array($iter) {
    foreach ($iter as $k => $v) {
        $array[$k] = $v;
    }
    return $array;
}

I think it's reasonable to expect that the code will behave this way.

If there are no objections I'd like to vote on this already on February
28th or March 1st. It is a few days shy of the 2 week discussion period,
but I'd like to have this in 5.5 and the beta is tagged on the 7th already
:)

Nikita

--bcaec55409808e58eb04d68dc61c--