Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66164
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mindplay.dk from 209.85.212.50 cause and error)
MIME-Version: 1.0
Date: Fri, 22 Feb 2013 16:29:12 -0500
Message-ID: <CADqTB_j1y+mz50d1x+YQJOmjw=6k9ra0k0T4SyAioG+Ea7tuoA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf307ca04cf1bd8f04d656e1c7
Subject: rfc:trailing-comma-function-args
From: rasmus@mindplay.dk (Rasmus Schultz)

--20cf307ca04cf1bd8f04d656e1c7
Content-Type: text/plain; charset=ISO-8859-1

I've been thinking about this RCF for a while now:

https://wiki.php.net/rfc/trailing-comma-function-args

It just doesn't seem necessary - the only time I've ever found something
like this to be necessary, is when a function takes closures or other very
long arguments, some of which are optional... but actually, writing this in
a VCS-friendly way is already possible:

$tree->traverse(
    $tree
    ,
    function($node) {
        // ...
    }
);

... version 2 ...

$tree->traverse(
    $tree
    ,
    function($node) {
        // ...
    }
    ,
    function($node) {
        // ...
    }
);

This actually comes out more legible, in my opinion.

What really irks me about this patch, is that the trailing comma implies
that another optional argument may exist - it really doesn't make the code
more intuitive to read. The example on the page (using fopen) really isn't
a realistic use-case - who would break a couple of simple arguments into
individual lines like that?

Just my two cents...

- Rasmus

--20cf307ca04cf1bd8f04d656e1c7--