Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66066
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CACzKMq314akxWO1TLWROobEKFNxxjPaTRscefSCFVrfB+Dg41g@mail.gmail.com>
References: <CACzKMq314akxWO1TLWROobEKFNxxjPaTRscefSCFVrfB+Dg41g@mail.gmail.com>
Date: Wed, 20 Feb 2013 19:35:21 +0100
Message-ID: <CAH-PCH4Q2mGxpOrweNkFyadW3uyskRZ-csw2wkS5Voa-BzJWTA@mail.gmail.com>
To: Paul Taulborg <njaguar@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae93409f7846e8704d62c3869
Subject: Re: [PHP-DEV] Re: [PATCH] (v 5.4.11-dev) ext/date/php_date.c cleanup
From: tyra3l@gmail.com (Ferenc Kovacs)

--14dae93409f7846e8704d62c3869
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 7, 2012 at 8:54 PM, Paul Taulborg <njaguar@gmail.com> wrote:

> Sorry for the double message, still getting used to doing patches
> instead of applying changes directly. I accidentally attached an old
> patch file, not the latest. The previous had a bug in
> php_date_initialize() which I caught in my testing (I left the local
> variable tzi, by mistake, instead of using now->tz_info), but didn't
> regenerate the patch file. Caught up upon reviewing the patch itself
> and realizing it was the old one. :-/
>
> Attached is the proper patch, thanks.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Hi,

Could you open a bug on http://bugs.php.net/ and attach the patch (or
create a pull request and link that)?
I think it would be also useful if you could split the changes into
separate two patches: one for the whitespace changes and one for the actual
code adjustments.
Thanks!

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--14dae93409f7846e8704d62c3869--