Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66060
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVo1z2RA=87GjJa9onW-i91wW_fQ=unED=bDK=LmrKwJ=g@mail.gmail.com>
References: <CAESVnVo1z2RA=87GjJa9onW-i91wW_fQ=unED=bDK=LmrKwJ=g@mail.gmail.com>
Date: Wed, 20 Feb 2013 14:43:06 +0100
Message-ID: <CAF+90c-n9qoUkkJBwSHSjju_vNjk7tKvy88inEBy3+P-dcEiqQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae93b57405a3bb504d62823d5
Subject: Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists
From: nikita.ppv@gmail.com (Nikita Popov)

--14dae93b57405a3bb504d62823d5
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Feb 19, 2013 at 1:06 PM, Sara Golemon <pollita@php.net> wrote:

> Opening RFC to allow trailing comma in function call argument lists
>
> https://wiki.php.net/rfc/trailing-comma-function-args
>

Imho this change isn't necessary (though I'm also not strongly against). I
don't really buy the VCS argument, as the usage of function argument lists
and arrays are quite different. Functions have a fixed parameter
specification, so you don't really "just add another argument" (exception:
variadics). Arrays are quite different in that regard.

Also in my personal experience people quite rarely use the
one-argument-per-line notation for functions. If the line gets to long
people split the arguments to an extra line, but usually it's not necessary
to wrap things across so many lines that these concerns become relevant. (I
mean, this is PHP and not the Win32API with 12-required-arguments
functions...)

I could see a minor benefit for code generation, though there too the
difference isn't really large (especially if you can use implode).

Nikita

--14dae93b57405a3bb504d62823d5--