Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66058
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.44 as permitted sender)
References: <CAESVnVo1z2RA=87GjJa9onW-i91wW_fQ=unED=bDK=LmrKwJ=g@mail.gmail.com> <CAESVnVp7gZQ3b0VWZsGhYosrovS3UgGFke1qa67hkmZTG2-M-g@mail.gmail.com> <20130220114733.GM31240@phcomp.co.uk>
Mime-Version: 1.0 (1.0)
In-Reply-To: <20130220114733.GM31240@phcomp.co.uk>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <37F31B39-13D1-4BDB-9741-727C7413A490@gmail.com>
Cc: Sara Golemon <pollita@php.net>,
 PHP internals <internals@lists.php.net>
Date: Wed, 20 Feb 2013 23:46:37 +1100
To: Alain Williams <addw@phcomp.co.uk>
Subject: Re: [PHP-DEV] Re: [RFC] Allow trailing comma in function call argument lists
From: davidkmuir@gmail.com (David Muir)



On 20/02/2013, at 10:47 PM, Alain Williams <addw@phcomp.co.uk> wrote:

> On Wed, Feb 20, 2013 at 03:26:26AM -0800, Sara Golemon wrote:
>> On Tue, Feb 19, 2013 at 4:06 AM, Sara Golemon <pollita@php.net> wrote:
>>> Opening RFC to allow trailing comma in function call argument lists
>>>=20
>>> https://wiki.php.net/rfc/trailing-comma-function-args
>> For the record, I've updated the RFC just now to include
>> function/method/closure declarations as well:
>>=20
>> function foo(
>>  $bar,
>>  $baz,
>> ) {
>>=20
>> }
>>=20
>> Not a pattern I see as much, but for the sake of consistency, it
>> doesn't hurt to put it on the table for discussion.
>=20
> I would argue against the RFC.
>=20
> The trailing comma is useful with arrays since it is not uncommon that mem=
bers
> need to be added to an array over time. This is often as a result of chang=
es
> outside of the program (eg: another user added to an ACL). Such a change d=
oes
> not alter the purpose or functionality that is represented by the array, i=
t just
> does it for more somethings (users in my example).
>=20
> Much source/version control is line based and so trailing commas helps kee=
p
> differences short.
>=20
> With functions: I do not see arguments being added in the same way, ie you=
 are
> getting the function to do more of the same by adding an extra argument. I=
f an
> extra argument is added it is because what the function does has changed i=
n some way.
> This is very different from the just-a-bit-more scenario that you have wit=
h arrays.
>=20
> If a function has a list of arguments that is expected to change, many
> programmers would do that by passing an array to the function and arrays c=
an
> already have trailing commands ....
>=20
> Also: many other languages (eg C, Perl) allow a trailing comma in arrays, b=
ut
> not to function arguments. This change would make PHP different from what m=
any
> programmers might expect.
>=20
> --=20
> Alain Williams
> Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT=
 Lecturer.
> +44 (0) 787 668 0256  http://www.phcomp.co.uk/
> Parliament Hill Computers Ltd. Registration Information: http://www.phcomp=
.co.uk/contact.php
> #include <std_disclaimer.h>
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20


The one place I would find this to be super handy would be when specifying a=
rguments to sprintf(), and other variable argument functions.

Cheers,=20
David=