Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66032
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVo1z2RA=87GjJa9onW-i91wW_fQ=unED=bDK=LmrKwJ=g@mail.gmail.com>
References: <CAESVnVo1z2RA=87GjJa9onW-i91wW_fQ=unED=bDK=LmrKwJ=g@mail.gmail.com>
Date: Wed, 20 Feb 2013 10:47:22 +0200
Message-ID: <CAA9esyT85FwNJUXRS6L1=OS8GzEOgVQy_DeUbEf3+cPZ80QODQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists
From: florinpatan@gmail.com (Florin Razvan Patan)

Hello,

On Tue, Feb 19, 2013 at 2:06 PM, Sara Golemon <pollita@php.net> wrote:
> Opening RFC to allow trailing comma in function call argument lists
>
> https://wiki.php.net/rfc/trailing-comma-function-args
>

As a person who deals with code reviews from many programmers
each day, I'd have to say this would be confusing. I do agree that
it helps consistency but by far it implies many things that are really
not what they seem.

For example, I would expect that if I have:

function A($b, $c = 'd') {}

when I see A($b, ) to have no syntax errors but rather $c defaulted to
the value in the function signature, which is not implied nor assumed
by the RFC but it would be by the one reading a function.

Then when I have

function A($b, $c = 'd', $e) {}

to be able to have A($b, , $e) which again this RFC doesn't specify
that it allows but leads to confusion.

As for the argument about the VCS, I really don't see an issue with
the current way of thing. Some people don't use the comma at the
end of the arrays and it doesn't mean that they all should.

So from my point of view, this adds more ambiguity to the language
and the problem it solves is very small.


Best regards,
Florin
----
Florin Patan
https://github.com/dlsniper