Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:66028 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49685 invoked from network); 20 Feb 2013 08:38:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Feb 2013 08:38:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.50 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.219.50 mail-oa0-f50.google.com Received: from [209.85.219.50] ([209.85.219.50:44423] helo=mail-oa0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FB/35-19387-07B84215 for ; Wed, 20 Feb 2013 03:38:09 -0500 Received: by mail-oa0-f50.google.com with SMTP id l20so7886503oag.9 for ; Wed, 20 Feb 2013 00:38:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=ZqvOvLMXeBiF1M5dJ+EARl8jVOQDcHwx+jS6FZp/Jeo=; b=S8Yi2s7OuVqpgEDZpeeSAoZ9pe4WScAw9FdHnQqOsmb1nMR7JcDKBgy1HFV4POABi/ 9IPK8YPFmv4dCgPRj94dYaf5JoryGYLyRGB9oPPzaRCFnYt4SbRIP7hdnjfkOQVKEpoO thDd7e3HRxL5nXF4GKamoY+C2Phj/s/rZxQ7Va2ug85+i+9HXZAqjRfj0dVnm3KWM0AW LxZ+lx4gSN+s/9ZpCcsiIi60mEQVhEHmHap+HK/lCa7NaD2HoNSY3nVMhJU085EqdVZY VSh0/vuThlVM0EMQHEeq2JFTUdtrm55lKesNts0UuKNB8izqw3Ue9D1XQpQ5iNLvktDu x33Q== MIME-Version: 1.0 X-Received: by 10.182.156.103 with SMTP id wd7mr8804304obb.33.1361349485559; Wed, 20 Feb 2013 00:38:05 -0800 (PST) Received: by 10.182.17.104 with HTTP; Wed, 20 Feb 2013 00:38:05 -0800 (PST) In-Reply-To: <51234477.7020607@sugarcrm.com> References: <51234477.7020607@sugarcrm.com> Date: Wed, 20 Feb 2013 11:38:05 +0300 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=f46d0444e835807dee04d623e081 X-Gm-Message-State: ALoCoQmNy3JvXCK+l4dZgZYXy5dmB8JDhkJGLMoZIOpfHOZSsK3lZASXGncUPhgnIN4dHMJUkkUewV9Kd7mj5RdPZKxBuz2FjwI0DpNf+UYcVrgs9LyAmaeSalehOx2iXNesD8QuiJwm Subject: Re: [PHP-DEV] bug 49348 - notice on $this->undefined++ From: dmitry@zend.com (Dmitry Stogov) --f46d0444e835807dee04d623e081 Content-Type: text/plain; charset=UTF-8 Hi Stas, The idea of the fix is fine (I didn't check all the related changes in PHP extensions). I think it must be included into 5.5. Thanks. Dmitry. On Tue, Feb 19, 2013 at 1:23 PM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlike > regular variables that do. > > Unfortunately, this fix seems to require changing signature of > get_property_ptr_ptr(), adding fetch type, which makes it impossible for > 5.4, and which would require any module that is compiled for 5.5 add > ifdefs if they override this handler (of course, I've fixed the ones in > the core). The pull is at: https://github.com/php/php-src/pull/281 > > However, I think that even though missing notice is not that big a deal, > having properties behaving inconsistently is, so this needs to be fixed. > Anybody has any objection or sees something wrong with the patch? > > Also, if somebody has an idea of a better fix that won't require > changing the API, it's be nice, I couldn't think of any. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --f46d0444e835807dee04d623e081--