Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66026
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 20 Feb 2013 09:25:32 +0100
To: <internals@lists.php.net>, <datibbaw@php.net>
Organization: =?UTF-8?Q?N=C3=BAcleo_de_Engenharia_Biom=C3=A9dica_do_Insti?=
 =?UTF-8?Q?tuto_Superior_T=C3=A9cnico?=
In-Reply-To: <CAHMUw2EL=V9tcJfwtsB_8bB2CZLJNQXGz=805a0b0pbiutPZ0w@mail.gmail.com>
References: <CAHMUw2EL=V9tcJfwtsB_8bB2CZLJNQXGz=805a0b0pbiutPZ0w@mail.gmail.com>
Message-ID: <8776954c4aac08ae337c130e18e89e24@nebm.ist.utl.pt>
User-Agent: RoundCube Webmail/0.8-rc
Subject: Re: [PHP-DEV] Question on hash api
From: glopes@nebm.ist.utl.pt (Gustavo Lopes)

Em 2013-02-20 8:09, Tjerk Anne Meesters escreveu:
> Hi,
>
> I've forked out an interesting project on Github that implements 
> XXHash and
> extended it to work with the hash() function family. Project links 
> below.
>
> The integration is pretty straightforward, but the following code had 
> me
> concerned:
>
> PHP_HASH_API void PHP_XXH32Update(PHP_XXH32_CTX *context, const 
> unsigned
> char *input, unsigned int inputLen)
> {
>         XXH32_feed(context->state, (void *)input, (int)inputLen);
> }
>
> The XXH32_feed() takes an int argument, whereas the update ops 
> function
> takes an unsigned int for the input length.
>
> Would that ever give a problem? If so, what kind of workaround am I 
> looking
> at?
>

Not unless and unsigned int with a value larger than INT_MAX is passed. 
I took a quick look at the calls to ->hash_update and the largest value 
potentially passed seems to be from a PHP string (via 
php_hash_hmac_round), which has an int for the length and therefore is 
not a problem.

-- 
Gustavo Lopes