Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:66019
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.47 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
Date: Wed, 20 Feb 2013 15:09:19 +0800
Message-ID: <CAHMUw2EL=V9tcJfwtsB_8bB2CZLJNQXGz=805a0b0pbiutPZ0w@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc05600bcd7b04d622a324
Subject: Question on hash api
From: datibbaw@php.net (Tjerk Anne Meesters)

--047d7bdc05600bcd7b04d622a324
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I've forked out an interesting project on Github that implements XXHash and
extended it to work with the hash() function family. Project links below.

The integration is pretty straightforward, but the following code had me
concerned:

PHP_HASH_API void PHP_XXH32Update(PHP_XXH32_CTX *context, const unsigned
char *input, unsigned int inputLen)
{
        XXH32_feed(context->state, (void *)input, (int)inputLen);
}

The XXH32_feed() takes an int argument, whereas the update ops function
takes an unsigned int for the input length.

Would that ever give a problem? If so, what kind of workaround am I looking
at?

Thanks!

Project links:

php-xxhash: https://github.com/datibbaw/php-xxhash
XXHash: http://code.google.com/p/xxhash/

--047d7bdc05600bcd7b04d622a324--