Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65991 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36389 invoked from network); 19 Feb 2013 19:57:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Feb 2013 19:57:58 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.47 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.219.47 mail-oa0-f47.google.com Received: from [209.85.219.47] ([209.85.219.47:33424] helo=mail-oa0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AE/F6-17768-549D3215 for ; Tue, 19 Feb 2013 14:57:58 -0500 Received: by mail-oa0-f47.google.com with SMTP id o17so7440918oag.34 for ; Tue, 19 Feb 2013 11:57:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=AU7Lm618QTKTyPFfCP/ip8CROrj/l0O+Fj9f58ncOGo=; b=mkS+F6iMxHmIOd1xFAZoLI8OiN5XiGhzTbZdK+etBCUPha5ub8BFXgemCbiQF/9X6N 7Flzh2TfRTeHrCz86vjkBXyJnfChFT/T+cBvT7iQYWr4qPw9vDR1GtEvPFgMsCkV2ttM JdVy5yiOS0F8HUYytCl8Bmdm2PnFpNhJ/bk/+ORToww/m+9V+FUgeClfVeClkeR05Y5K GyCyneeZDIxuOfU4lRVAm4l9HnNQ02Br2L3d3QWi8494FnSQspVxpg7TpF/NJCCHp0Q/ sqCHR/GMZ8LylxClaj/Zb54reqXMEZdILg5WluzLcfGc8lQ/Pdw7NEEaNgS9nfCXsbJo 388A== MIME-Version: 1.0 X-Received: by 10.60.18.136 with SMTP id w8mr120977oed.84.1361303875425; Tue, 19 Feb 2013 11:57:55 -0800 (PST) Received: by 10.182.17.104 with HTTP; Tue, 19 Feb 2013 11:57:55 -0800 (PST) In-Reply-To: <51234477.7020607@sugarcrm.com> References: <51234477.7020607@sugarcrm.com> Date: Tue, 19 Feb 2013 22:57:55 +0300 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=e89a8fb1f04ced15e204d6194171 X-Gm-Message-State: ALoCoQky0EIPzrNDUsK4UG+HddofPDVU8n9sBh2rItU/2neeq1okzL7Ii50UJaWnF9E7vu4DR7FD4+c4ysNz9G5GqzotCNuQvtU8zFwTUru/4yy84POGWKnhc6bCS6jUp1tukb01ea5X Subject: Re: [PHP-DEV] bug 49348 - notice on $this->undefined++ From: dmitry@zend.com (Dmitry Stogov) --e89a8fb1f04ced15e204d6194171 Content-Type: text/plain; charset=UTF-8 Hi Stas, I'll take a look tomorrow or after tomorrow. Sorry, quite busy. Thanks. Dmitry. On Tue, Feb 19, 2013 at 1:23 PM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlike > regular variables that do. > > Unfortunately, this fix seems to require changing signature of > get_property_ptr_ptr(), adding fetch type, which makes it impossible for > 5.4, and which would require any module that is compiled for 5.5 add > ifdefs if they override this handler (of course, I've fixed the ones in > the core). The pull is at: https://github.com/php/php-src/pull/281 > > However, I think that even though missing notice is not that big a deal, > having properties behaving inconsistently is, so this needs to be fixed. > Anybody has any objection or sees something wrong with the patch? > > Also, if somebody has an idea of a better fix that won't require > changing the API, it's be nice, I couldn't think of any. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --e89a8fb1f04ced15e204d6194171--