Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65953
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.54 as permitted sender)
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <alpine.DEB.2.02.1302191351290.5054@whisky.home.derickrethans.nl>
References: <CAF+90c-F4DO93owuYOHOVjnEwEmohiTiUMU6VXM2t1+PRSzKaQ@mail.gmail.com>
 <alpine.DEB.2.02.1302191323090.5054@whisky.home.derickrethans.nl>
 <CACQesk5TykzLe==yCrDXg3zh+XfLahhBu7yOFdKeKjDBYzaXCA@mail.gmail.com> <alpine.DEB.2.02.1302191351290.5054@whisky.home.derickrethans.nl>
Date: Tue, 19 Feb 2013 15:12:16 +0100
Message-ID: <CACQesk4WuORy6snpu-izF2TwFqCBnzCPMQDzn8L+ho+iDuwmHA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf30334c5b0e836904d6146fc4
Subject: Re: [PHP-DEV] [RFC] Allow non-scalar keys in foreach
From: colder@php.net (Etienne Kneuss)

--20cf30334c5b0e836904d6146fc4
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 19, 2013 at 2:55 PM, Derick Rethans <derick@php.net> wrote:

> Gah, no top posting!
>
> On Tue, 19 Feb 2013, Etienne Kneuss wrote:
>
> > On Tue, Feb 19, 2013 at 2:25 PM, Derick Rethans <derick@php.net> wrote:
> >
> > > On Tue, 19 Feb 2013, Nikita Popov wrote:
> > >
> > > > This RFC proposes to remove the type-restrictions on Iterator keys
> > > > used in foreach:
> > > >
> > > > https://wiki.php.net/rfc/foreach-non-scalar-keys
> > > >
> > > > I took over Levi's RFC and added a patch for it.
> > >
> > > Under "Open Questions" you write:
> > >
> > > > What should be done with the keys that are valid in the iterator,
> > > > but not in the array? I think the best approach would be to just
> > > > set the array keys with the exact same semantics as PHP would do
> > > > (i.e. with all casts and warnings).
> > >
> > > Would __toString be called in case the key was an object?
>
> > I think the warning can stay as-is, __toString is not necessarily
> > available so casting to string in all occasions is probably not what
> > we want.
>
> I think it should cast to a string if possible. You are now making
> iterator_to_array not work with the new feature, and I find that a bit
> silly. Whether it should be __toString (or __toKey) I don't really care,
> but this new support for objects should be supported everywhere (and
> that includes iterator_to_array).
>

I think this RFC is orthogonal to iterator_to_array supporting conversions
from objects to keys.

$array[$obj] = 42; does not call __toString (or __toKey), it throws a
catchable fatal. IMO it would be inconsistent if iterator_to_array
gracefully accepted objects as keys.

--20cf30334c5b0e836904d6146fc4--