Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6595
Return-Path: <rrichards@ctindustries.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 88561 invoked by uid 1010); 19 Dec 2003 11:42:55 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 88537 invoked from network); 19 Dec 2003 11:42:55 -0000
Received: from unknown (HELO phoebe.host4u.net) (209.150.128.26)
  by pb1.pair.com with SMTP; 19 Dec 2003 11:42:55 -0000
Received: from ctdprimary (dsta-aa203.pivot.net [66.186.171.203])
	by phoebe.host4u.net (8.11.6/8.11.6) with SMTP id hBJBgms11758;
	Fri, 19 Dec 2003 05:42:54 -0600
Message-ID: <079301c3c625$75e8b360$f7dea8c0@cyberware.local>
To: <internals@lists.php.net>, <andi@zend.com>
References: <20031218124303.18e22274.paj@pearfr.org> <20031218124303.18e22274.paj@pearfr.org> <5.1.0.14.2.20031218201056.07660648@localhost> <3FE22229.9010209@phpbar.de>
Date: Fri, 19 Dec 2003 06:44:10 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Subject: Re: [PHP-DEV] B3, pear segfault
From: rrichards@ctindustries.net ("Rob Richards")

Did the problem end up being due to zend_execute.c 1.566 patch?

Within the zend_assign_to_object function, the temp variable needs to be
free'd, otherwise it needs to be handled within the extensions themselves.
Not sure about the other functions in that patch as I only ran into issues
with this function so far in some of the extensions.

ex.

$dom=new domDocument();
$dom->preserveWhiteSpace=false; <-  leaks

$array = simplexml_load_string('<array><data>sample data</data></array>');
$array->data = false; <- leaks and is valid syntax as it gets converted to
string

Within dom (pre 1.566 patch) , I had been handling this in my property write
function (removed the other day) via:
if (! PZVAL_IS_REF(value) && value->refcount == 0) {
 value->refcount++;
 zval_ptr_dtor(&value);
}

Does this need to go back in or is the code from the 1.566 patch going to be
revisited and re-implemented?

Rob