Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65945
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1302191323090.5054@whisky.home.derickrethans.nl>
References: <CAF+90c-F4DO93owuYOHOVjnEwEmohiTiUMU6VXM2t1+PRSzKaQ@mail.gmail.com>
	<alpine.DEB.2.02.1302191323090.5054@whisky.home.derickrethans.nl>
Date: Tue, 19 Feb 2013 14:30:05 +0100
Message-ID: <CAF+90c-VvBxphLJU5ZBFvOLj7xE1oqVVKDHzkSnyf3D0OkXAtg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec54d475ceeaf2b04d613d692
Subject: Re: [PHP-DEV] [RFC] Allow non-scalar keys in foreach
From: nikita.ppv@gmail.com (Nikita Popov)

--bcaec54d475ceeaf2b04d613d692
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Feb 19, 2013 at 2:25 PM, Derick Rethans <derick@php.net> wrote:

> On Tue, 19 Feb 2013, Nikita Popov wrote:
>
> > This RFC proposes to remove the type-restrictions on Iterator keys
> > used in foreach:
> >
> > https://wiki.php.net/rfc/foreach-non-scalar-keys
> >
> > I took over Levi's RFC and added a patch for it.
>
> Under "Open Questions" you write:
>
> > What should be done with the keys that are valid in the iterator, but
> not in
> > the array? I think the best approach would be to just set the array keys
> with
> > the exact same semantics as PHP would do (i.e. with all casts and
> warnings).
>
> Would __toString be called in case the key was an object?
>

Current behavior of PHP can be found here:
http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_execute.c#996 So if one goes
with that approach, then no, __toString won't be called, it'll throw a "*
Warning*: Illegal offset type" and not set the key. Don't know whether
that's good or bad ^^

Nikita

--bcaec54d475ceeaf2b04d613d692--