Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65926 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10713 invoked from network); 19 Feb 2013 09:32:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Feb 2013 09:32:45 -0000 Authentication-Results: pb1.pair.com header.from=theanomaly.is@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=theanomaly.is@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender) X-PHP-List-Original-Sender: theanomaly.is@gmail.com X-Host-Fingerprint: 74.125.82.50 mail-wg0-f50.google.com Received: from [74.125.82.50] ([74.125.82.50:37420] helo=mail-wg0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C4/B0-04083-CB643215 for ; Tue, 19 Feb 2013 04:32:45 -0500 Received: by mail-wg0-f50.google.com with SMTP id es5so5396356wgb.5 for ; Tue, 19 Feb 2013 01:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=xhM53KRNolPDaaMAMYuAnAOaA0pX86Kgo1ZXAf/tA9c=; b=R79An97yNbve0h/eJt3/q2kA0PoetyTIVAryCxZd50iTmfaL/J7MbDvAOq4zL9ZLdE QUC3+okFDm6F06uD4QwL7gLywsIyod+W43F964QPZ4zDqHa5K6qCX753D7XZ7bYtkCDq VYnWpltbx8c//RnDTORk5Yres44SsUOs//d3KQMFkbfy1UScHevp9bVcZWY3iisOUlKG uk4tCISvjK2BfD68oAYw3nxRZ/FEf8N1sEDTTDOQUgOjp043GnseNHIADTa1au2+TYSO IZjCwnQfmsW6e+Cdj2Io3J4qiNt//Q8BMajleLNxJDqnql16/5G99OrzDB4Qq/X86ulF ePMA== MIME-Version: 1.0 X-Received: by 10.194.158.165 with SMTP id wv5mr24591430wjb.45.1361266361851; Tue, 19 Feb 2013 01:32:41 -0800 (PST) Received: by 10.227.42.135 with HTTP; Tue, 19 Feb 2013 01:32:41 -0800 (PST) In-Reply-To: <51234477.7020607@sugarcrm.com> References: <51234477.7020607@sugarcrm.com> Date: Tue, 19 Feb 2013 04:32:41 -0500 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: multipart/alternative; boundary=089e0122ef88f15e8a04d610851d Subject: Re: [PHP-DEV] bug 49348 - notice on $this->undefined++ From: theanomaly.is@gmail.com (Sherif Ramadan) --089e0122ef88f15e8a04d610851d Content-Type: text/plain; charset=ISO-8859-1 On Tue, Feb 19, 2013 at 4:23 AM, Stas Malyshev wrote: > Hi! > > I've created a pull to fix bug 49348 - when undefined properties do not > produce a notice when doing something like $this->undefined++, unlike > regular variables that do. > > Unfortunately, this fix seems to require changing signature of > get_property_ptr_ptr(), adding fetch type, which makes it impossible for > 5.4, and which would require any module that is compiled for 5.5 add > ifdefs if they override this handler (of course, I've fixed the ones in > the core). The pull is at: https://github.com/php/php-src/pull/281 > > However, I think that even though missing notice is not that big a deal, > having properties behaving inconsistently is, so this needs to be fixed. > Anybody has any objection or sees something wrong with the patch? > > Looks like a reasonable fix to me. It's unfortunate it has to wait for 5.5, but I couldn't think of a more clever fix that wouldn't break the API. > Also, if somebody has an idea of a better fix that won't require > changing the API, it's be nice, I couldn't think of any. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --089e0122ef88f15e8a04d610851d--