Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65925
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.193 as permitted sender)
Message-ID: <51234477.7020607@sugarcrm.com>
Date: Tue, 19 Feb 2013 01:23:03 -0800
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: bug 49348 - notice on $this->undefined++
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

I've created a pull to fix bug 49348 - when undefined properties do not
produce a notice when doing something like $this->undefined++, unlike
regular variables that do.

Unfortunately, this fix seems to require changing signature of
get_property_ptr_ptr(), adding fetch type, which makes it impossible for
5.4, and which would require any module that is compiled for 5.5 add
ifdefs if they override this handler (of course, I've fixed the ones in
the core). The pull is at: https://github.com/php/php-src/pull/281

However, I think that even though missing notice is not that big a deal,
having properties behaving inconsistently is, so this needs to be fixed.
Anybody has any objection or sees something wrong with the patch?

Also, if somebody has an idea of a better fix that won't require
changing the API, it's be nice, I couldn't think of any.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227