Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65904
Return-Path: <glopes@nebm.ist.utl.pt>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 27700 invoked from network); 17 Feb 2013 23:38:36 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Feb 2013 23:38:36 -0000
Authentication-Results: pb1.pair.com header.from=glopes@nebm.ist.utl.pt; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=glopes@nebm.ist.utl.pt; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
X-PHP-List-Original-Sender: glopes@nebm.ist.utl.pt
X-Host-Fingerprint: 193.136.128.21 smtp1.ist.utl.pt Linux 2.6
Received: from [193.136.128.21] ([193.136.128.21:45204] helo=smtp1.ist.utl.pt)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 61/72-12059-9F961215 for <internals@lists.php.net>; Sun, 17 Feb 2013 18:38:34 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by smtp1.ist.utl.pt (Postfix) with ESMTP id A451D700043D;
	Sun, 17 Feb 2013 23:38:30 +0000 (WET)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at ist.utl.pt
Received: from smtp1.ist.utl.pt ([127.0.0.1])
	by localhost (smtp1.ist.utl.pt [127.0.0.1]) (amavisd-new, port 10025)
	with LMTP id ieTs8NDD61nM; Sun, 17 Feb 2013 23:38:30 +0000 (WET)
Received: from mail2.ist.utl.pt (mail.ist.utl.pt [IPv6:2001:690:2100:1::8])
	by smtp1.ist.utl.pt (Postfix) with ESMTP id 203FC7000437;
	Sun, 17 Feb 2013 23:38:29 +0000 (WET)
Received: from damnation.nl.lo.geleia.net (unknown [IPv6:2001:470:94a2:4:21d:baff:feee:cc0b])
	(Authenticated sender: ist155741)
	by mail2.ist.utl.pt (Postfix) with ESMTPSA id B969E2009016;
	Sun, 17 Feb 2013 23:38:28 +0000 (WET)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Remi Collet" <remi@fedoraproject.org>, "Stas Malyshev"
 <smalyshev@sugarcrm.com>
Cc: "PHP Internals" <internals@lists.php.net>
References: <511666DE.8080809@fedoraproject.org>
 <51172819.4000806@sugarcrm.com> <51174790.8040805@fedoraproject.org>
 <511751C5.1020906@fedoraproject.org> <51175BDD.9040705@sugarcrm.com>
 <op.wsad6bs3idpuyk@damnation.nl.lo.geleia.net>
 <op.wsao7qs7idpuyk@damnation.nl.lo.geleia.net>
 <5117BA92.8080307@fedoraproject.org>
 <op.wsa1omtoidpuyk@damnation.nl.lo.geleia.net>
 <511890AC.7080506@fedoraproject.org> <51189847.5030506@sugarcrm.com>
Date: Mon, 18 Feb 2013 00:38:24 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.wsobyaxwidpuyk@damnation.nl.lo.geleia.net>
In-Reply-To: <51189847.5030506@sugarcrm.com>
User-Agent: Opera Mail/12.12 (Linux)
Subject: Re: [PHP-DEV] double val to long val conversion issue
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Mon, 11 Feb 2013 08:05:43 +0100, Stas Malyshev <smalyshev@sugarcrm.com>  
wrote:

>>> This was I was afraid. That bug was just the tip of the iceberg. I
>>> suggest we do change the the > operator to >= like you proposed,
>>
>> I will do it later today.
>
> >= may be fine, but I am concerned about fmod change for 5.4. If we do
> it, I'm afraid we may change some scenario, so I'd prefer to make it 5.5
> only.

If no one objects, I'll merge this into 5.5 and master:

https://github.com/cataphract/php-src/compare/dval_to_lval


-- 
Gustavo Lopes