Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65748
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ellisons.org.uk from 79.170.44.47 cause and error)
Message-ID: <51173F0C.2020403@ellisons.org.uk>
Date: Sun, 10 Feb 2013 06:32:44 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: PHP Internals <internals@lists.php.net>
References: <511666DE.8080809@fedoraproject.org> <CAEZPtU7wNj3GDD6GbLkZ-6KRAV_62Hj5QYzGiD7kLObtEbfEmg@mail.gmail.com> <5116D57F.6030802@ellisons.org.uk> <5117131B.2040606@sugarcrm.com>
In-Reply-To: <5117131B.2040606@sugarcrm.com>
Content-Type: multipart/alternative;
 boundary="------------050400010605050506070809"
Subject: Re: [PHP-DEV] double val to long val conversion issue
From: Terry@ellisons.org.uk (Terry Ellison)

--------------050400010605050506070809
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 10/02/13 03:25, Stas Malyshev wrote:
>
>> these onto the appropriate visualC / gcc types.  As far as I can see,
>> PHP doesn't and seems to use long and int almost interchangeably which
> PHP indeed does not use fixed-size types in zvals, etc. but it
> definitely does not "use long and int almost interchangeably". In almost
> any place where int is used instead of long or vice versa (unless it is
> a specific small value that is nowhere near limits of either int or long
> and used in very restricted context) - it is a bug and should be fixed.
> If you know of such places, please name them or even better, submit a
> bug report pointing them out.
Stan, you are right to correct me.  Sorry.  However, I still feel that 
the implicit assumption is that sizeof(long) == 2*sizeof(int) and this 
isn't the case with visualC, and PHP internal data structures compiled 
with visualC and gcc are significantly different; for example hash keys 
are 32 bits long on Windows and 64bits on *nix.  Why aren't they 32bits, 
say, on both? (as there is no performance benefit is having 64bit hash 
keys when the maximum size of a hash table is an int).

--------------050400010605050506070809--