Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65737 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72366 invoked from network); 8 Feb 2013 23:13:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2013 23:13:35 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.181 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.223.181 mail-ie0-f181.google.com Received: from [209.85.223.181] ([209.85.223.181:54361] helo=mail-ie0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 04/76-18015-E9685115 for ; Fri, 08 Feb 2013 18:13:35 -0500 Received: by mail-ie0-f181.google.com with SMTP id 17so5728573iea.12 for ; Fri, 08 Feb 2013 15:13:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ntklesk7sm8pvUMRtp94ubJl7x7p4P98OMwp+VsnVGA=; b=gGucgb8hPpNqnzCG5/ES+J20zlqV3lpn+/REbsykwt4qk1t9iAB4BvTqlx1fovaHJt heRdAoij1mwbmHopmktgjT+LE93fGFPA4kJgMqDtqFYco6YN7KNHXFFYtnJ8X7wZaqzr 5DGRs0n+YIrCpdB2tJOV427zG02XTR4CY3ltIfOCq7A2KHRHYwAO8MgGu26sbcsMJp74 50HAwMrZw5jJ1U18eBlEnvRXfV1DIPYNgpUbXsAzpRQSNlLA+D0tD6HXAgjyAcLzoMey I2+tLPefnXJuyX3A9PbbttQjwUWSMPKyi95OhtY5nCv1mXPk0qVrt+RzmkvDnZhLxRK3 S+2Q== MIME-Version: 1.0 X-Received: by 10.50.7.234 with SMTP id m10mr6075811iga.43.1360365212109; Fri, 08 Feb 2013 15:13:32 -0800 (PST) Received: by 10.50.106.138 with HTTP; Fri, 8 Feb 2013 15:13:31 -0800 (PST) In-Reply-To: References: <2B76A3EF-66AC-4E73-B186-236E9C2AE891@gmail.com> <5113AE8F.4060402@2bepublished.at> <5114B537.2050802@2bepublished.at> Date: Sat, 9 Feb 2013 00:13:31 +0100 Message-ID: To: Keyur Govande Cc: Christoph Rosse , PHP Internals Content-Type: multipart/alternative; boundary=f46d04462dd43b8ad904d53eb584 Subject: Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI From: tyra3l@gmail.com (Ferenc Kovacs) --f46d04462dd43b8ad904d53eb584 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Feb 8, 2013 at 10:16 PM, Keyur Govande wrot= e: > On Fri, Feb 8, 2013 at 4:01 PM, Ferenc Kovacs wrote: > >> >> >> >> On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wr= ote: >> >>> On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse >> >wrote: >>> >>> > Hi, >>> > >>> > could you rename these functions to: >>> > >>> > cli_process_set_title >>> > cli_process_get_title >>> > >>> > http://www.php.net/manual-**lookup.php?pattern=3Dset_&scope=3D**quick= ref< >>> http://www.php.net/manual-lookup.php?pattern=3Dset_&scope=3Dquickref> >>> >>> > gives me a lot of hits like: >>> > >>> > xml_parser_set_options >>> > stream_set_read_buffer >>> > pg_set_info >>> > ps_set_border_color >>> > >>> > etc. >>> > >>> > its also a lot more readable as it is: object_action_subject. >>> > >>> >>> Done. In keeping with "object_action_subject" as suggested by Christoph= , >>> I >>> renamed the methods: cli_(get/set)_process_title. Patch updated: >>> https://gist.github.com/keyurdg/4728770 >>> >>> Since there's consensus around this, I'm moving this RFC to voting stat= e. >>> >> >> I think that one day is a little bit stretching the line of the minimum >> required discussion period: >> https://wiki.php.net/rfc/voting#discussion_period >> > > Ah my bad :) I'll hold off on sending the [VOTE] email. > thanks! --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --f46d04462dd43b8ad904d53eb584--