Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65734 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 61521 invoked from network); 8 Feb 2013 21:16:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2013 21:16:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=keyurgovande@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=keyurgovande@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.170 as permitted sender) X-PHP-List-Original-Sender: keyurgovande@gmail.com X-Host-Fingerprint: 209.85.212.170 mail-wi0-f170.google.com Received: from [209.85.212.170] ([209.85.212.170:60242] helo=mail-wi0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/E4-18015-51B65115 for ; Fri, 08 Feb 2013 16:16:06 -0500 Received: by mail-wi0-f170.google.com with SMTP id hm11so1465577wib.3 for ; Fri, 08 Feb 2013 13:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=hfIWx+UoJIuQUTk8ntGKcAHhcfpv6hufUvepU41fJNM=; b=TEFgqOeRSyGoU8htzzipUQOEplAIO8zZyZ7px4lGMClBn695DGC80p0hOn17nWpS1t Vu/2KR6+hS4hc+wbIdZxOAwmj3chwXn8YXAFfxdEgQ4fcTEyV5UTfz1s17cLMChohVbS faaQ26fSRseIhoE2P+llhj9C7nnXr6UnbEDHCXK62OwYQ60N9z2v7vNLX3tJn7cch3zd Loksu0yDSIyEDxBUwh/iEcAtC/+ZBQcO+uPXYZaNFvinMVpF+pOkZBHQg08Flp2DL1nq mJdMIb+cIWDwVq35Yvg1H/sBv3rtdjW4GOfMtcI2CxBoeqMhKpc2V45d0iJTsPiW/jIo o+4w== MIME-Version: 1.0 X-Received: by 10.180.81.164 with SMTP id b4mr4940385wiy.34.1360358162462; Fri, 08 Feb 2013 13:16:02 -0800 (PST) Received: by 10.227.61.18 with HTTP; Fri, 8 Feb 2013 13:16:02 -0800 (PST) In-Reply-To: References: <2B76A3EF-66AC-4E73-B186-236E9C2AE891@gmail.com> <5113AE8F.4060402@2bepublished.at> <5114B537.2050802@2bepublished.at> Date: Fri, 8 Feb 2013 16:16:02 -0500 Message-ID: To: Ferenc Kovacs Cc: Christoph Rosse , PHP Internals Content-Type: multipart/alternative; boundary=14dae9cc9fbe0a784104d53d1113 Subject: Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI From: keyurgovande@gmail.com (Keyur Govande) --14dae9cc9fbe0a784104d53d1113 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Feb 8, 2013 at 4:01 PM, Ferenc Kovacs wrote: > > > > On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote: > >> On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse > >wrote: >> >> > Hi, >> > >> > could you rename these functions to: >> > >> > cli_process_set_title >> > cli_process_get_title >> > >> > http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickref< >> http://www.php.net/manual-lookup.php?pattern=set_&scope=quickref> >> >> > gives me a lot of hits like: >> > >> > xml_parser_set_options >> > stream_set_read_buffer >> > pg_set_info >> > ps_set_border_color >> > >> > etc. >> > >> > its also a lot more readable as it is: object_action_subject. >> > >> >> Done. In keeping with "object_action_subject" as suggested by Christoph, I >> renamed the methods: cli_(get/set)_process_title. Patch updated: >> https://gist.github.com/keyurdg/4728770 >> >> Since there's consensus around this, I'm moving this RFC to voting state. >> > > I think that one day is a little bit stretching the line of the minimum > required discussion period: > https://wiki.php.net/rfc/voting#discussion_period > Ah my bad :) I'll hold off on sending the [VOTE] email. --14dae9cc9fbe0a784104d53d1113--