Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65732 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57960 invoked from network); 8 Feb 2013 21:01:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2013 21:01:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.177 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.223.177 mail-ie0-f177.google.com Received: from [209.85.223.177] ([209.85.223.177:54709] helo=mail-ie0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9D/24-18015-C9765115 for ; Fri, 08 Feb 2013 16:01:17 -0500 Received: by mail-ie0-f177.google.com with SMTP id 16so5571652iea.22 for ; Fri, 08 Feb 2013 13:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=SoXuX69z04zQtLuWYuiAFYe36N/1abXHrQ0Dv2hiY30=; b=IwY7ZDWLSPLWJwAkeBG+mXo3B8n8p/E/pcIEwXHkxfr77DPlwnLguiuMj8+lDPiLQ6 K4cf2MgpgmENirQlXxt9fyWAYafh1gpgM4ezoItOzXCzZsmA5M8FKcXDTEz7PaZSpFrh b/MW35ZDxhjwMMSLId9ob4473GOWaekhzNgnRQuDpZoFLdHvux5s2FMiLAfmw/65MzHC okjaAQb3O5/kiGi0xlhKCpaWSM3nE2VfftczWc9JaQ2NKwngzB9sQIJf1JM5VAG4uMd/ OPXjRIgMEFi7PQ0s4eIPNxIoLwIN5Dq+AdeTKVCm9BkpnUWDpgVwXrsAS6JszGOHNzHK J+ZA== MIME-Version: 1.0 X-Received: by 10.42.58.202 with SMTP id j10mr11236008ich.39.1360357273254; Fri, 08 Feb 2013 13:01:13 -0800 (PST) Received: by 10.50.106.138 with HTTP; Fri, 8 Feb 2013 13:01:13 -0800 (PST) In-Reply-To: References: <2B76A3EF-66AC-4E73-B186-236E9C2AE891@gmail.com> <5113AE8F.4060402@2bepublished.at> <5114B537.2050802@2bepublished.at> Date: Fri, 8 Feb 2013 22:01:13 +0100 Message-ID: To: Keyur Govande Cc: Christoph Rosse , PHP Internals Content-Type: multipart/alternative; boundary=20cf303346130a3c5b04d53cdc49 Subject: Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI From: tyra3l@gmail.com (Ferenc Kovacs) --20cf303346130a3c5b04d53cdc49 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote= : > On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse >wrote: > > > Hi, > > > > could you rename these functions to: > > > > cli_process_set_title > > cli_process_get_title > > > > http://www.php.net/manual-**lookup.php?pattern=3Dset_&scope=3D**quickre= f< > http://www.php.net/manual-lookup.php?pattern=3Dset_&scope=3Dquickref> > > gives me a lot of hits like: > > > > xml_parser_set_options > > stream_set_read_buffer > > pg_set_info > > ps_set_border_color > > > > etc. > > > > its also a lot more readable as it is: object_action_subject. > > > > Done. In keeping with "object_action_subject" as suggested by Christoph, = I > renamed the methods: cli_(get/set)_process_title. Patch updated: > https://gist.github.com/keyurdg/4728770 > > Since there's consensus around this, I'm moving this RFC to voting state. > I think that one day is a little bit stretching the line of the minimum required discussion period: https://wiki.php.net/rfc/voting#discussion_period --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --20cf303346130a3c5b04d53cdc49--