Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65731 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55461 invoked from network); 8 Feb 2013 20:30:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2013 20:30:30 -0000 Authentication-Results: pb1.pair.com header.from=keyurgovande@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=keyurgovande@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender) X-PHP-List-Original-Sender: keyurgovande@gmail.com X-Host-Fingerprint: 74.125.82.172 mail-we0-f172.google.com Received: from [74.125.82.172] ([74.125.82.172:42195] helo=mail-we0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6B/C3-18015-56065115 for ; Fri, 08 Feb 2013 15:30:29 -0500 Received: by mail-we0-f172.google.com with SMTP id x10so3335560wey.31 for ; Fri, 08 Feb 2013 12:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ZmwWvl0jE97aa9NfFOnt0Hfx1AOIKFnpFwQZerODbs0=; b=I0Lw4V7c9mncySxYxk+z6QQOUQeMoTxA/AUstgNXdfulvX6rOZ5mcnqz7XziTeLtPO ZjmHDqZxjUeZLiBMKJ6Ydiiz8CC6nyTnSBB9z9owfCd6WqXba94py06V0rsvf5ratQLC nhRL+HLECFCCvMeK5YyKROXh5S1JNtJza5vQnpP657IzG1CLWUOFvfRohmFn0gUrWJ+k Qo4P3MyTX4/ldiHImpQ+DzXZuUK6/CM7F6WpnT/T1QGnbGYLCMNSm+Q34wTb8lmeetPR w1Xj7iaTjSrSeMXTXaxrccjShQC64gKW6K8Gc3ciOB2RgBswFyRIsmpKKjyYQ7J8dStx QknQ== MIME-Version: 1.0 X-Received: by 10.194.123.105 with SMTP id lz9mr12137509wjb.43.1360355426553; Fri, 08 Feb 2013 12:30:26 -0800 (PST) Received: by 10.227.61.18 with HTTP; Fri, 8 Feb 2013 12:30:26 -0800 (PST) In-Reply-To: <5114B537.2050802@2bepublished.at> References: <2B76A3EF-66AC-4E73-B186-236E9C2AE891@gmail.com> <5113AE8F.4060402@2bepublished.at> <5114B537.2050802@2bepublished.at> Date: Fri, 8 Feb 2013 15:30:26 -0500 Message-ID: To: Christoph Rosse Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=089e01177699f7cfb104d53c6d20 Subject: Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI From: keyurgovande@gmail.com (Keyur Govande) --089e01177699f7cfb104d53c6d20 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse wrote: > Hi, > > could you rename these functions to: > > cli_process_set_title > cli_process_get_title > > http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickref > gives me a lot of hits like: > > xml_parser_set_options > stream_set_read_buffer > pg_set_info > ps_set_border_color > > etc. > > its also a lot more readable as it is: object_action_subject. > Done. In keeping with "object_action_subject" as suggested by Christoph, I renamed the methods: cli_(get/set)_process_title. Patch updated: https://gist.github.com/keyurdg/4728770 Since there's consensus around this, I'm moving this RFC to voting state. --089e01177699f7cfb104d53c6d20--