Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65699
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BDF0960A-4B7C-453F-ADA3-99991402FD46@gmail.com>
References: <CALrkBjZ1Jb9k1=b8uyqbmaMojw06vSaAZCMfDU3LnXGP2cWEMw@mail.gmail.com>
	<CACQesk6dr8+0CkAgZOca5L=PipdPbt8sSFf_qvUn7r5pjqXnYg@mail.gmail.com>
	<CAAyV7nFV6bT822U+BkydhrVWZ8nq8ROPZXq4UZpKy12_UG6fcw@mail.gmail.com>
	<BDF0960A-4B7C-453F-ADA3-99991402FD46@gmail.com>
Date: Wed, 6 Feb 2013 12:15:33 -0500
Message-ID: <CAAyV7nFycMywoCruqt3ORsfdrG7y2vHB9SLS63mY-GGJ4A_-dA@mail.gmail.com>
To: Tyler Sommer <sommertm@gmail.com>
Cc: Etienne Kneuss <colder@php.net>, Mike Willbanks <pencap@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0434bf0c4f8ec304d511797d
Subject: Re: [PHP-DEV] ArrayAccess/ArrayObject return by reference
From: ircmaxell@gmail.com (Anthony Ferrara)

--f46d0434bf0c4f8ec304d511797d
Content-Type: text/plain; charset=ISO-8859-1

Tyler,

References are indicated by the function signature, so:

interface ArrayAccessReference {
    public function &offsetGet($key);
    public function offsetSet($key, $value);
    public function offsetIsset($key);
    public function offsetUnset($key);
}


On Wed, Feb 6, 2013 at 12:09 PM, Tyler Sommer <sommertm@gmail.com> wrote:

> How would the interface enforce returning a reference?
>
>
> On Feb 6, 2013, at 8:47 AM, Anthony Ferrara <ircmaxell@gmail.com> wrote:
>
> > Perhaps there's another way out of this. A simple way would be to
> introduce
> > an ArrayAccessReference interface in core that adds the references to the
> > getters/setters...
> >
> > It's perhaps not the cleanest, but it solves the BC issues...
> >
> > Anthony
> >
> >
> > On Wed, Feb 6, 2013 at 11:42 AM, Etienne Kneuss <colder@php.net> wrote:
> >
> >> I assume it would be possible technically but might break (at least by
> >> issuing E_STRICT) a lot of code if we forced ArrayObject::offsetGet to
> >> return a reference.
> >>
> >> Think of all the subclasses that extend ArrayObject who currently do
> not do
> >> that?
> >>
> >> Other than that, returning a ref where it previously didn't can have all
> >> kinds of undesirable and hard-to-track consequences.
> >>
> >> Best,
> >>
> >>
> >> On Wed, Feb 6, 2013 at 4:27 PM, Mike Willbanks <pencap@gmail.com>
> wrote:
> >>
> >>> Looking at:
> http://lxr.php.net/xref/PHP_5_5/Zend/zend_interfaces.c#538it
> >>> seems that ArrayAccess at the moment can not be returned by a
> reference.
> >>> I'm wondering if there was a technical reason behind this or if it is
> >> now
> >>> a BC reason?
> >>>
> >>> Anyhow; I was attempting to dig through the source code a bit more last
> >>> night to see why ArrayObject could not overload the function
> declaration
> >> of
> >>> offsetGet to force a return by reference aka: function
> >> &offsetGet($key)...
> >>> which works now for ArrayAccess but not for ArrayObject.  I believe it
> >> has
> >>> to deal with ArrayObject inheriting ArrayAccess?  Is there a way to
> allow
> >>> ArrayObject to change the function declaration in this way?  My PHP
> >>> internals skills are not the best which is the reason for the question.
> >>>
> >>> Anyhow; justification wise: in userland this leads to a lot of wtf
> >> factor.
> >>> It really comes down to having to provide our own implementation of
> >>> ArrayObject by extending several different areas including ArrayAccess
> so
> >>> that references can be returned so multi-dimensional arrays can be
> >> properly
> >>> unset aka:
> >>> $ar = new ArrayObject(array('foo' => array('bar' => array('baz' =>
> >>> 'foo'))));
> >>> unset($ar['foo']['bar']['baz']);
> >>>
> >>> Regards,
> >>>
> >>> Mike
> >>>
> >>
> >>
> >>
> >> --
> >> Etienne Kneuss
> >> http://www.colder.ch
> >>
>
>

--f46d0434bf0c4f8ec304d511797d--