Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65653
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Npxu5AmzKg=bobHqXRHvi6NH1TH3Nq0RknU8+X_sGF7Ow@mail.gmail.com>
References: <CAFMT4Npxu5AmzKg=bobHqXRHvi6NH1TH3Nq0RknU8+X_sGF7Ow@mail.gmail.com>
Date: Mon, 4 Feb 2013 22:17:52 +0100
Message-ID: <CAH-PCH4thB4woZ5qrF1p8rmAqY-Z=vMzddAaK+ru46GcWgnsmg@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae934125544cb5404d4eca037
Subject: Re: [PHP-DEV] PHP 5.4.11 tests: floating point diff
From: tyra3l@gmail.com (Ferenc Kovacs)

--14dae934125544cb5404d4eca037
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 4, 2013 at 9:50 PM, Levi Morrison <levim@php.net> wrote:

> I have been compiling PHP under various compilers trying to figure out
> what flags I need for each compiler to pass all tests excluding
> XFAILs. With Intel 13.0.1 I'm down to two failing tests:
>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> FAILED TEST SUMMARY
> ---------------------------------------------------------------------
> Test fmod() - basic function test fmod()
> [ext/standard/tests/math/fmod_basic.phpt]
> Test fmod function : 64bit long tests
> [ext/standard/tests/math/fmod_basiclong_64bit.phpt]
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> The only differences are between -0 and 0 (exact diffs at end of message)=
.
>
> My understanding of floating point calculations is that -0 and 0 are
> equivalent, so I can safely ignore the failures. I wanted to first
> check to make sure that is actually true.
>
> Assuming that the above is correct, I wanted to patch the phpt files
> for the tests to pass. However, I'm not very familiar with that
> format.  How would you suggest altering the tests to make this pass?
>
> ----------
>
> cat ext/standard/tests/math/fmod_basic.diff
> 016+ float(0)
> 017+ float(0)
> 016- float(-0)
> 017- float(-0)
> 020+ float(0)
> 021+ float(0)
> 022+ float(0)
> 020- float(-0)
> 021- float(-0)
> 022- float(-0)
> 026+ float(0)
> 026- float(-0)
>
> cat ext/standard/tests/math/fmod_basiclong_64bit.diff
> 026+ float(0)
> 026- float(-0)
> 028+ float(0)
> 028- float(-0)
> 040+ float(0)
> 040- float(-0)
> 042+ float(0)
> 042- float(-0)
> 044+ float(0)
> 044- float(-0)
> 070+ float(0)
> 070- float(-0)
> 072+ float(0)
> 072- float(-0)
> 084+ float(0)
> 084- float(-0)
> 114+ float(0)
> 114- float(-0)
> 116+ float(0)
> 116- float(-0)
> 128+ float(0)
> 128- float(-0)
> 158+ float(0)
> 158- float(-0)
> 160+ float(0)
> 160- float(-0)
> 290+ float(0)
> 290- float(-0)
> 292+ float(0)
> 292- float(-0)
> 304+ float(0)
> 304- float(-0)
> 306+ float(0)
> 306- float(-0)
> 308+ float(0)
> 308- float(-0)
> 312+ float(0)
> 312- float(-0)
> 314+ float(0)
> 314- float(-0)
> 326+ float(0)
> 326- float(-0)
> 328+ float(0)
> 328- float(-0)
> 330+ float(0)
> 330- float(-0)
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
hi,

you could use EXPECTREGEX (
http://qa.php.net/phpt_details.php#expectregex_section) with something like
float\([\+\-]*0\)

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--14dae934125544cb5404d4eca037--