Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:65641 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42771 invoked from network); 4 Feb 2013 17:28:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Feb 2013 17:28:29 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain zend.com does not designate 209.85.219.45 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 209.85.219.45 mail-oa0-f45.google.com Received: from [209.85.219.45] ([209.85.219.45:58768] helo=mail-oa0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 97/A0-38697-CBFEF015 for ; Mon, 04 Feb 2013 12:28:29 -0500 Received: by mail-oa0-f45.google.com with SMTP id o6so6920274oag.32 for ; Mon, 04 Feb 2013 09:28:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=3WKiUbA42Cv2M4OkLtu+7vcSHLCbZH13Q1wPNex9xmo=; b=VfQWn4OHijn/QZqqTpgnGYw5lqHGGDB7V0AEHXAjFL2jcu6wFIk9iwVH9kAF045Zaj gE4g+02AlEEZurHLhLYM20sPDJLANQOkWvse9KbolRRFWfEZhQjq0VDLkEucHKQAIhUl iWvGC7z2teq7xX9VOW0Bgfk97HmQ8RvP7R8NxldH+6ri2+4sEDxXg9lqed/JJbXIvkJM JealcPlMh4s1w4gXPWQoYFiut9QkmTypHM4CfBBzIMKuEI0kgTKIbUSFeYH2BmcOtWn1 6bmS/mipUyzr0AMZWOGHhsTlhjVZmvQ2L8FSCtLTFhngSwg4hdlq9NaA6+GRvmE8PkXW wVvg== MIME-Version: 1.0 X-Received: by 10.182.92.70 with SMTP id ck6mr15975391obb.46.1359998906389; Mon, 04 Feb 2013 09:28:26 -0800 (PST) Received: by 10.182.17.104 with HTTP; Mon, 4 Feb 2013 09:28:26 -0800 (PST) In-Reply-To: <510FE909.3030903@linaro.org> References: <510FE909.3030903@linaro.org> Date: Mon, 4 Feb 2013 20:28:26 +0300 Message-ID: To: Ard Biesheuvel Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=14dae93b63dab5d55404d4e96b4c X-Gm-Message-State: ALoCoQmW2XR3j1kKkWLS9gJT1h0ORCoffrmfT/+WHtSrOBid72kL2l5/1BayORHYb1SCvm7NWQ+N86LMEcMaP44Kn9qOwBpAYBIdr79NviMgbV/eW3JMWdrTyvn6dHnFo+iXxWFjfEWr Subject: Re: [PHP-DEV] more inline assembler noise From: dmitry@zend.com (Dmitry Stogov) --14dae93b63dab5d55404d4e96b4c Content-Type: text/plain; charset=UTF-8 On Mon, Feb 4, 2013 at 8:59 PM, Ard Biesheuvel wrote: > On 02/04/2013 01:50 PM, Dmitry Stogov wrote: > >> I can't remember if I did any special benchmarks except for bench.php when >> I introduced fast math functions. >> That time, I rearranged the code to allow inlining of the most probable >> paths and added assembler code to catch overflow (C can't do it in optimal >> way). As I remember the bench.php showed some visible improvement. >> >> > OK, in that case I would still recommend using fewer hardcoded numbers and > offsets: please refer to the applied patch, it makes things a bit more > robust. > I completely agree with you and I'll try to fix it when have time. > However, as I don't expect any speedup for ARM in this area, I will not > pursue this any further. > I'm not familiar with ARM architecture, so I don't know if inline assembler may improve performance. > Are there any other optimizations involving inline assembler that you > implemented for PHP? I would like to review them to see if I need to add an > ARM version. > You may take a look into zend_alloca.c. It uses special x86 instructions for bit scanning and overflow checking during address calculation. Thanks. Dmitry. > Cheers, > > Ard. > > > --14dae93b63dab5d55404d4e96b4c--