Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:65634
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.21 as permitted sender)
To: "'Gustavo Lopes'" <glopes@nebm.ist.utl.pt>,
	"'Patrick Schaaf'" <php@bof.de>,
	<internals@lists.php.net>
Cc: "'Derick Rethans'" <derick@php.net>,
	"'Martin Jansen'" <martin@divbyzero.net>
References: <510EA95F.40503@divbyzero.net> <alpine.DEB.2.02.1302031737430.5054@whisky.home.derickrethans.nl> <2835262.zO39iNXCyM@rofl> <002d01ce02c8$dbb6d430$93247c90$@Liepert@gmx.de> <op.wrzbosnpidpuyk@damnation.nl.lo.geleia.net>
In-Reply-To: <op.wrzbosnpidpuyk@damnation.nl.lo.geleia.net>
Date: Mon, 4 Feb 2013 14:27:01 +0100
Message-ID: <003401ce02db$53073e00$f915ba00$@Liepert@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: Ac4Cy29YGVAzNLdIS3apFBGAj8P41AAD9PzQ
Content-Language: de
Subject: AW: AW: [PHP-DEV] FILTER_VALIDATE_INT and +0/-0
From: Frank.Liepert@gmx.de ("Frank Liepert")

> So the question is only whether "+0" or "-0" (or "+0", etc.) should be
> accepted as integers by FILTER_VALIDATE_INT. I think they should,
> because
> we also accept non-canonical inputs such as "+5", i.e., we always
> accept a
> sign. It's true that 0 is neither positive or negative, but I don't
> think
> "accepts a leading sign, except if it's 0" is a good option. It's an
> unnecessary special case.

I was misguided by two statements, I'm sorry.

The 1st: In my opinion FILTER_VALIDATE_INT must work like var_dump(-0); =
(BR #54096)
The 2nd: "Treat "+0" and "-0" as valid integers just like var_dump() =
does." (https://github.com/php/php-src/pull/248)

Both statements are wrong, since the purpose of the filter extension is =
to validate strings. I found this information in BR #52884 (see last =
comment). Maybe it should be added to the docs? It's nonsense to say, =
that FILTER_VALIDATE_INT must work like var_dump() since they are both =
serving different purposes.

With this information I agree on your opinion.

var_dump(filter_var('-0',FILTER_VALIDATE_INT)); // int(0) instead of the =
prior bool(false)
var_dump('-0'); // string(2) "-0"
var_dump(is_int('-0')); // bool(false)